From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] USB: remove info() macro from usb input drivers Date: Fri, 10 Oct 2008 09:11:39 -0700 (PDT) Message-ID: <20081010.091139.264833623.davem@davemloft.net> References: <20081010050305.GA32476@kroah.com> <20081010134207.GA10688@anvil.corenet.prv> <20081010155221.GC20231@kroah.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:34721 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1760704AbYJJQME (ORCPT ); Fri, 10 Oct 2008 12:12:04 -0400 In-Reply-To: <20081010155221.GC20231@kroah.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: greg@kroah.com Cc: dmitry.torokhov@gmail.com, linux-input@vger.kernel.org, linux-usb@vger.kernel.org From: Greg KH Date: Fri, 10 Oct 2008 08:52:21 -0700 > On Fri, Oct 10, 2008 at 09:42:07AM -0400, Dmitry Torokhov wrote: > > On Thu, Oct 09, 2008 at 10:03:05PM -0700, Greg KH wrote: > > > From: Greg Kroah-Hartman > > > > > > USB should not be having it's own printk macros, so remove info() and > > > use the system-wide standard of dev_info() wherever possible. > > > > > > Cc: Dmitry Torokhov > > > Signed-off-by: Greg Kroah-Hartman > > > > > > --- > > > Dmitry, this has been in the USB tree for a few months now, sorry for > > > not sending it to you sooner. I can easily keep it in my tree and send > > > it to Linus for this merge if you want me to, or you can take it in your > > > tree, which ever you want me to do. > > > > > > > Greg, just push it through your tree since it's already there. I don't > > think we have any clashes in this code. > > Great, thanks for letting me know. Right, and Jeff is away until next week so even more reason for you to take care of it via the USB tree :-)