linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ivo van Doorn <ivdoorn@gmail.com>
To: Dmitry Baryshkov <dbaryshkov@gmail.com>
Cc: linux-wireless@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH] RFKILL: fix input layer initialisation
Date: Wed, 22 Oct 2008 19:05:58 +0200	[thread overview]
Message-ID: <200810221905.58169.IvDoorn@gmail.com> (raw)
In-Reply-To: <1224694375-29318-1-git-send-email-dbaryshkov@gmail.com>

On Wednesday 22 October 2008, Dmitry Baryshkov wrote:
> Initialise correctly last fields, so tasks can be actually executed.
> On some architectures the initial jiffies value is not zero, so later
> all rfkill incorrectly decides that rfkill_*.last is in future.
> 
> Signed-off-by: Dmitry Baryshkov <dbaryshkov@gmail.com>
> ---
>  net/rfkill/rfkill-input.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/net/rfkill/rfkill-input.c b/net/rfkill/rfkill-input.c
> index e5b6955..cd93f48 100644
> --- a/net/rfkill/rfkill-input.c
> +++ b/net/rfkill/rfkill-input.c
> @@ -255,6 +255,11 @@ static struct input_handler rfkill_handler = {
>  
>  static int __init rfkill_handler_init(void)
>  {
> +	unsigned long last_run = jiffies - msecs_to_jiffies(500);
> +	rfkill_wlan.last = last_run;
> +	rfkill_bt.last = last_run;
> +	rfkill_uwb.last = last_run;
> +	rfkill_wimax.last = last_run;
>  	return input_register_handler(&rfkill_handler);
>  }

I believe Dmitry Torokhov recently moved the rfkill structures for wlan, bt, etc
into an array which allowed for easy looping through all structures. That would
make updating all entries easier (and less prone to errors when a new structure
is added).

Could you rebase thise patch on top of that one?
Thanks,

Ivo

  reply	other threads:[~2008-10-22 17:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-22 16:52 [PATCH] RFKILL: fix input layer initialisation Dmitry Baryshkov
2008-10-22 17:05 ` Ivo van Doorn [this message]
     [not found]   ` <200810221905.58169.IvDoorn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2008-10-28 12:33     ` Dmitry
2008-10-22 17:15 ` Henrique de Moraes Holschuh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200810221905.58169.IvDoorn@gmail.com \
    --to=ivdoorn@gmail.com \
    --cc=dbaryshkov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).