From: Andrew Morton <akpm@linux-foundation.org>
To: Andreas Schwab <schwab@suse.de>
Cc: linux-kernel@vger.kernel.org, linux-input@ver.kernel.org
Subject: Re: [PATCH] Fix hid_device_id for cross compiling
Date: Thu, 30 Oct 2008 00:23:32 -0700 [thread overview]
Message-ID: <20081030002332.4ef1fac4.akpm@linux-foundation.org> (raw)
In-Reply-To: <jevdvgl345.fsf@sykes.suse.de>
On Sun, 26 Oct 2008 00:30:18 +0200 Andreas Schwab <schwab@suse.de> wrote:
> struct hid_device_id contains hidden padding which is bad for cross
> compiling. Make the padding explicit and consistent across
> architectures.
>
What is "bad" about it? Can you expand a bit on the problem which is
being fixed here? Before-and-after user-visible behaviour?
Thanks.
> ---
> diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h
> index eb71b45..0e4f303 100644
> --- a/include/linux/mod_devicetable.h
> +++ b/include/linux/mod_devicetable.h
> @@ -135,6 +135,7 @@ struct usb_device_id {
>
> struct hid_device_id {
> __u16 bus;
> + __u16 pad1;
> __u32 vendor;
> __u32 product;
> kernel_ulong_t driver_data
next prev parent reply other threads:[~2008-10-30 7:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-25 22:30 [PATCH] Fix hid_device_id for cross compiling Andreas Schwab
2008-10-30 7:23 ` Andrew Morton [this message]
2008-10-30 9:19 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081030002332.4ef1fac4.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-input@ver.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).