From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Henrik Rydberg <rydberg@euromail.se>,
Andrew Morton <akpm@linux-foundation.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input: Map missing keys to appropriate functions
Date: Tue, 11 Nov 2008 13:50:30 -0500 [thread overview]
Message-ID: <20081111134955.ZZRA012@mailhub.coreip.homeip.net> (raw)
In-Reply-To: <alpine.LNX.1.10.0811111826270.24889@jikos.suse.cz>
On Tue, Nov 11, 2008 at 06:27:42PM +0100, Jiri Kosina wrote:
> On Tue, 4 Nov 2008, Henrik Rydberg wrote:
>
> > On macbooks there are specific keys for the user-space functions Expose
> > and Dashboard, which currently has no counterpart in input.h. This patch
> > adds KEY_SCALE and KEY_DASHBOARD, and maps the keyboard accordingly.
> > Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
> > ---
> > drivers/hid/hid-apple.c | 5 +++--
> > include/linux/input.h | 2 ++
> [ ... ]
> > diff --git a/include/linux/input.h b/include/linux/input.h
> > index b86fb55..5341e82 100644
> > --- a/include/linux/input.h
> > +++ b/include/linux/input.h
> > @@ -238,6 +238,7 @@ struct input_absinfo {
> > #define KEY_KPEQUAL 117
> > #define KEY_KPPLUSMINUS 118
> > #define KEY_PAUSE 119
> > +#define KEY_SCALE 120 /* AL Compiz Scale (Expose) */
> >
> > #define KEY_KPCOMMA 121
> > #define KEY_HANGEUL 122
> > @@ -322,6 +323,7 @@ struct input_absinfo {
> > #define KEY_PAUSECD 201
> > #define KEY_PROG3 202
> > #define KEY_PROG4 203
> > +#define KEY_DASHBOARD 204 /* AL Dashboard */
> > #define KEY_SUSPEND 205
> > #define KEY_CLOSE 206 /* AC Close */
> > #define KEY_PLAY 207
>
> Dmitry, could you please Ack this? Is it OK if I take it through my tree,
> together with the hid-apple mapping update? Thanks.
>
Sorry, running a bit behind... Yep, please take these through your
tree.
--
Dmitry
next prev parent reply other threads:[~2008-11-11 18:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-04 12:31 [PATCH] input: Map missing keys to appropriate functions Henrik Rydberg
2008-11-11 17:27 ` Jiri Kosina
2008-11-11 18:50 ` Dmitry Torokhov [this message]
2008-11-11 22:33 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081111134955.ZZRA012@mailhub.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).