Re: [patch] add module parameter to provide hardware-calibrated coordinate data for MicroTouch/3M touchscreens

[Greg KH <greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>]

On Thu, Nov 13, 2008 at 03:22:52PM -0500, Dan Streetman wrote:
> Back in mtouchusb, I added the "raw_coordinates" module parameter to
> make it possible to get the hw-calib data:
> http://marc.info/?l=linux-usb-devel&m=110968309531306&w=2
> 
> When mtouchusb was integrated into the usbtouchscreen driver, that
> ability wasn't carried over - it reports only the raw coordinates
> again.
> 
> This patch restores the ability to get hardware-calibrated coordinate
> data, and defaults to the raw data so existing systems with a
> microtouch touchscreen won't see any changes.
> 
> Note that the Y axis is inverted as reported by the touchscreen, so
> this reverses the Y min and max (0xffff for the min, 0 for the max).
> This works fine on my system using the X evdev driver.
> 
> (I'm sending this from gmail which hopefully won't mangle the
> patch...I tested it and it seems ok)
> 
> Signed-off-by: Dan Streetman <ddstreet-EkmVulN54Sk@public.gmane.org>
> 
> 
> --- a/drivers/input/touchscreen/usbtouchscreen.c	2008-11-12
> 13:06:23.000000000 -0500
> +++ b/drivers/input/touchscreen/usbtouchscreen.c	2008-11-12
> 13:07:44.000000000 -0500

Your patch is line-wrapped :(

> @@ -60,6 +60,10 @@ static int swap_xy;
>  module_param(swap_xy, bool, 0644);
>  MODULE_PARM_DESC(swap_xy, "If set X and Y axes are swapped.");
> 
> +static int hwcalib_xy = 0;
> +module_param(hwcalib_xy, bool, 0444);
> +MODULE_PARM_DESC(hwcalib_xy, "If set hw-calibrated X/Y are used if available");

Should this variable be allowed to be changed at run time?  That might
be useful if the code is built into the system.  If so, please change
the permissions on the module_param() call.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html