From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Kleen Subject: Re: [PATCH 1/1 v2] HID: don't grab devices with no input Date: Fri, 14 Nov 2008 14:17:01 +0100 Message-ID: <20081114131701.GI3810@one.firstfloor.org> References: <491CA495.7010007@gmail.com> <1226614221-17118-1-git-send-email-jirislaby@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from one.firstfloor.org ([213.235.205.2]:41416 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751126AbYKNNHj (ORCPT ); Fri, 14 Nov 2008 08:07:39 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Jiri Kosina Cc: Jiri Slaby , Alan Stern , Andi Kleen , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org On Fri, Nov 14, 2008 at 12:02:27PM +0100, Jiri Kosina wrote: > On Thu, 13 Nov 2008, Jiri Slaby wrote: > > > Some devices have no input interrupt endpoint. These won't be handled > > by usbhid, but currently they are not refused and reside on hid bus. > > Perform this checking earlier so that we refuse to control such > > a device early enough (and not pass it to the hid bus at all). > > Signed-off-by: Jiri Slaby > > As the patch is obviously correct(tm) :) I have queued it in my tree, but > Andi, please still report back whether it fixes the issue you are seeing. sispm works again with that patch. Thanks. The only nit I noticed is that the error message seems to miss an \n -Andi