linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vojtech Pavlik <vojtech@suse.cz>
To: Dan Streetman <ddstreet@ieee.org>
Cc: linux-usb@vger.kernel.org, linux-input@vger.kernel.org,
	Greg KH <greg@kroah.com>,
	daniel.ritz@gmx.ch
Subject: Re: [patch] add module parameter to provide hardware-calibrated coordinate data for MicroTouch/3M touchscreens
Date: Fri, 14 Nov 2008 22:31:25 +0100	[thread overview]
Message-ID: <20081114213125.GA6995@suse.cz> (raw)
In-Reply-To: <3fad22b40811131222k3a168a06tfe01b09ca106e0a2@mail.gmail.com>

On Thu, Nov 13, 2008 at 03:22:52PM -0500, Dan Streetman wrote:

> Note that the Y axis is inverted as reported by the touchscreen, so
> this reverses the Y min and max (0xffff for the min, 0 for the max).
> This works fine on my system using the X evdev driver.

> +	// Default min/max xy are the raw values, override if using hw-calib
> +	if (hwcalib_xy) {
> +		input_set_abs_params(usbtouch->input, ABS_X, 0, 0xffff, 0, 0);
> +		input_set_abs_params(usbtouch->input, ABS_Y, 0xffff, 0, 0, 0);

While it does work with the X evdev, please don't do it, and instead do
the inversion before reporting ABS_Y. Linux input devices should follow
the (USB) HID specification of axis direction and stick to it. The
behaviour with reversed min/max is undefined.

-- 
Vojtech Pavlik
Director SuSE Labs

  parent reply	other threads:[~2008-11-14 21:32 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-13 20:22 [patch] add module parameter to provide hardware-calibrated coordinate data for MicroTouch/3M touchscreens Dan Streetman
     [not found] ` <3fad22b40811131222k3a168a06tfe01b09ca106e0a2-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-11-13 20:31   ` Greg KH
2008-11-14 21:31 ` Vojtech Pavlik [this message]
2008-11-14 21:46   ` Dan Streetman
2008-11-15 21:08     ` Vojtech Pavlik
  -- strict thread matches above, loose matches on Subject: below --
2008-11-13 23:25 Dan Streetman
2008-11-13 23:36 ` Alexey Klimov
2008-11-14  0:03 ` Greg KH
2008-11-14 16:17 Dan Streetman
2008-11-17 16:26 Dan Streetman
2008-11-24 14:57 Dan Streetman
     [not found] ` <alpine.LNX.1.10.0811240944520.4090-ah6mVDs4vN4u9rY2yWxFjw@public.gmane.org>
2008-11-25 15:27   ` Jiri Kosina
2008-11-25 16:29 Dan Streetman
2008-12-02 19:35 ` Dan Streetman
     [not found] ` <3fad22b40812021135v78410015ya0ea1bd149beeb0a@mail.gmail.com>
2008-12-12 17:40   ` Dan Streetman
     [not found] ` <alpine.LNX.1.10.0811251035260.30650-ah6mVDs4vN4u9rY2yWxFjw@public.gmane.org>
2009-01-08  0:52   ` Jiri Kosina
     [not found]     ` <alpine.LRH.1.10.0901080149280.24105-1ReQVI26iDCaZKY3DrU6dA@public.gmane.org>
2009-01-11  7:58       ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081114213125.GA6995@suse.cz \
    --to=vojtech@suse.cz \
    --cc=daniel.ritz@gmx.ch \
    --cc=ddstreet@ieee.org \
    --cc=greg@kroah.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).