Re: [RFC 2.6.27 1/1] Add support for Wacom W8001 penabled serial touchscreen

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

Hi Jaya,

On Wed, Nov 19, 2008 at 01:14:26PM +0800, Jaya Kumar wrote:
> Hi Dmitry, linux-input,
> 
> I am resending this patch which I had posted a few weeks back. I would really
> appreciate any feedback.
> 
> Thanks,
> jaya
> 
> 
> The Wacom W8001 sensor is a sensor device (uses electromagnetic resonance)
> and it is interfaced via its serial microcontroller to the host.
> 
> Signed-off-by: Jaya Kumar <jayakumar.lkml@gmail.com>
> 

Overall looks good, with the following exceptions:

- you don't seem to report tilt events although you parse the data;
- you don't neet to have cmd_mutex since you call w8001_command just
  once upon initialization; you don't need to re-init completion
  either. I'd also remove w8001_async_command and just did serio_write
  of that 1 character rigth in w8001_connect.
- I wouldn't use expected_packet but rather examine return of
  wait_for_completion_timeout to figure out if query succeeded or not.

Thanks!

-- 
Dmitry