From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: stefan@datenfreihafen.org
Cc: eric.y.miao@gmail.com, linux-arm-kernel@lists.arm.linux.org.uk,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Daniel Ribeiro <drwyrm@gmail.com>
Subject: Re: [patch 08/14] input: PCAP2 based touchscreen driver
Date: Fri, 21 Nov 2008 12:05:20 -0500 [thread overview]
Message-ID: <20081121170518.GA4416@USFSHXP-002051> (raw)
In-Reply-To: <20081121160521.959037675@dodger.lab.datenfreihafen.org>
On Fri, Nov 21, 2008 at 05:04:11PM +0100, stefan@datenfreihafen.org wrote:
> Touchscreen driver based on the PCAP2 multi function device.
>
> Signed-off-by: Daniel Ribeiro <drwyrm@gmail.com>
>
> +
> +static int __devexit pcap_ts_remove(struct platform_device *pdev)
> +{
> + ezx_pcap_unregister_event(PCAP_IRQ_TS);
> +
> + del_timer_sync(&pcap_ts->timer);
> +
> + input_unregister_device(pcap_ts->input);
> + kfree(pcap_ts);
> +
Could pcap_ts->work be still running at this point?
> + return 0;
> +}
> +
> +}
> +#else
> +
> +#define pcap_ts_suspend NULL
> +#define pcap_ts_resume NULL
> +
> +#endif
> +
> +static struct platform_driver pcap_ts_driver = {
> + .probe = pcap_ts_probe,
> + .remove = __devexit_p(pcap_ts_remove),
> + .suspend = pcap_ts_suspend,
> + .resume = pcap_ts_resume,
I think it is preferred that .suspend and .resume assigments are
guarded by #ifdef CONFIG_PM, not creating NULL stubs as this will
(theoretically) allow removing .suspend and .resume pointers from
driver stucture when compiling without PM support.
Also try running through checkpatch.pl - there are a few warnings I'd
like to be fixed as well. Otherwise looks pretty good.
Oh, and you need to add your sign-off please. Thanks!
--
Dmitry
next prev parent reply other threads:[~2008-11-21 17:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20081121160403.073751031@dodger.lab.datenfreihafen.org>
2008-11-21 16:04 ` [patch 08/14] input: PCAP2 based touchscreen driver stefan
2008-11-21 17:05 ` Dmitry Torokhov [this message]
2008-11-22 0:00 ` Stefan Schmidt
2009-04-21 2:18 ` Dmitry Torokhov
2009-04-21 2:38 ` Daniel Ribeiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081121170518.GA4416@USFSHXP-002051 \
--to=dmitry.torokhov@gmail.com \
--cc=drwyrm@gmail.com \
--cc=eric.y.miao@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stefan@datenfreihafen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).