linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Daniel Mierswa <impulze@impulze.org>
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH] Fujitsu Amilo PA 1510 key-release events quirk
Date: Sat, 29 Nov 2008 23:38:26 -0800	[thread overview]
Message-ID: <20081129233826.be959cae.akpm@linux-foundation.org> (raw)
In-Reply-To: <4931BB48.9010706@impulze.org>

On Sat, 29 Nov 2008 22:59:36 +0100 Daniel Mierswa <impulze@impulze.org> wrote:

> heya,
> the fujitsu amilo pa 1510 laptop needs a little lovin' regarding the 
> release event of the volume up and down keys. I attached a format-patch 
> (against torvalds/linux-2.6.git ed313489badef16d7) which separates the 
> generation of release events for certain scancodes into a macro since 3 
> dmi matches are already using it and generation of the missing release 
> events for that particular laptop. Please post back with any advice and 
> thoughts for that patch.
> 

Please don't send more than one patch per email.  I shall comment on
the two patches in two separate replies.

> From a197dfb0eed23b87418c0a7fe6a562910046576e Mon Sep 17 00:00:00 2001
> From: Daniel Mierswa <impulze@impulze.org>
> Date: Sat, 29 Nov 2008 22:39:34 +0100
> Subject: [PATCH] Separate macro for generation of keyrelease events
> 
> ---
>  drivers/input/keyboard/atkbd.c |   23 +++++++++++++----------
>  1 files changed, 13 insertions(+), 10 deletions(-)

Please also cc linux-input@vger.kernel.org on input-related patches.

> diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
> index 22016ca..99ef522 100644
> --- a/drivers/input/keyboard/atkbd.c
> +++ b/drivers/input/keyboard/atkbd.c
> @@ -834,6 +834,17 @@ static void atkbd_disconnect(struct serio *serio)
>  }
>  
>  /*
> + * generate release events for the keycodes given in forced_release_keys[]
> + */
> +#define GEN_RELEASE_EVENT \
> +	int i; \
> +\
> +	if (atkbd->set == 2) \
> +		for (i = 0; i < ARRAY_SIZE(forced_release_keys); i++) \
> +			__set_bit(forced_release_keys[i], \
> +				atkbd->force_release_mask);
> +
> +/*
>   * Most special keys (Fn+F?) on Dell laptops do not generate release
>   * events so we have to do it ourselves.
>   */
> @@ -842,12 +853,8 @@ static void atkbd_dell_laptop_keymap_fixup(struct atkbd *atkbd)
>  	const unsigned int forced_release_keys[] = {
>  		0x85, 0x86, 0x87, 0x88, 0x89, 0x8a, 0x8b, 0x8f, 0x93,
>  	};
> -	int i;
>  
> -	if (atkbd->set == 2)
> -		for (i = 0; i < ARRAY_SIZE(forced_release_keys); i++)
> -			__set_bit(forced_release_keys[i],
> -				  atkbd->force_release_mask);
> +	GEN_RELEASE_EVENT
>  }
>  
>  /*
> @@ -859,12 +866,8 @@ static void atkbd_hp_keymap_fixup(struct atkbd *atkbd)
>  	const unsigned int forced_release_keys[] = {
>  		0x94,
>  	};
> -	int i;
>  
> -	if (atkbd->set == 2)
> -		for (i = 0; i < ARRAY_SIZE(forced_release_keys); i++)
> -			__set_bit(forced_release_keys[i],
> -					atkbd->force_release_mask);
> +	GEN_RELEASE_EVENT
>  }

oh my.  Please, no.  Just write a C function:

void atkbd_gen_release_event(unsigned int *keys, unsigned nr_keys)
{
	...
}



       reply	other threads:[~2008-11-30  7:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4931BB48.9010706@impulze.org>
2008-11-30  7:38 ` Andrew Morton [this message]
2008-11-30  7:42   ` [PATCH] Fujitsu Amilo PA 1510 key-release events quirk Andrew Morton
2008-12-01 20:59   ` [PATCH] Fujitsu Amilo PA 1510 key-release events quirk (PATCH 1/3) Daniel Mierswa
2008-12-01 21:00   ` [PATCH] Fujitsu Amilo PA 1510 key-release events quirk (PATCH 2/3) Daniel Mierswa
2008-12-01 21:01   ` [PATCH] Fujitsu Amilo PA 1510 key-release events quirk (PATCH 3/3) Daniel Mierswa
2008-12-03  6:11     ` Andrew Morton
2008-11-30  7:41 ` [PATCH] Fujitsu Amilo PA 1510 key-release events quirk Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081129233826.be959cae.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=impulze@impulze.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).