From: Lauri Leukkunen <lauri.leukkunen-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
To: ext Sam Ravnborg <sam-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org>
Cc: dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>,
linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
"linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Mailing
List" <linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] Add TI TSC2005 Touchscreen driver
Date: Tue, 9 Dec 2008 15:17:05 +0200 [thread overview]
Message-ID: <20081209131705.GC6667@pure.research.nokia.com> (raw)
In-Reply-To: <20081208182648.GA9740-QabhHTsIXMSnlFQ6Q1D1Y0B+6BGkLq7r@public.gmane.org>
On 08/12/08 19:26 +0100, ext Sam Ravnborg wrote:
> > Add Texas Instruments TSC2005 chip touchscreen driver.
> >
> > Signed-off-by: Trilok Soni <soni.trilok-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> Hi Trilok.
> A few nitpicks below.
>
> In general a very clean written driver with adequate comments - nice work!
Umm, isn't this code mostly written by Nokia? At least I remember modifying
some of it, and this version looks like Konsta Karsisto might be the last
person touching it. Originally I think it's written by Imre Deak, probably
based on the tsc2301 code.
/lauri
------------------------------------------------------------------------------
SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
The future of the web can't happen without you. Join us at MIX09 to help
pave the way to the Next Web now. Learn more and register at
http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
next prev parent reply other threads:[~2008-12-09 13:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-08 17:49 [PATCH] Add TI TSC2005 Touchscreen driver Trilok Soni
2008-12-08 18:26 ` Sam Ravnborg
[not found] ` <20081208182648.GA9740-QabhHTsIXMSnlFQ6Q1D1Y0B+6BGkLq7r@public.gmane.org>
2008-12-09 13:17 ` Lauri Leukkunen [this message]
2008-12-10 7:14 ` Trilok Soni
2008-12-18 7:55 ` Trilok Soni
2008-12-08 18:28 ` Felipe Balbi
2009-01-03 4:38 ` Trilok Soni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081209131705.GC6667@pure.research.nokia.com \
--to=lauri.leukkunen-xnzwkgviw5gavxtiumwx3w@public.gmane.org \
--cc=david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org \
--cc=dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sam-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).