From: Arjan Opmeer <arjan@opmeer.net>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "Alexander E. Patrakov" <patrakov@gmail.com>,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: 2.6.28 thinks that my PS/2 mouse is a touchpad
Date: Tue, 30 Dec 2008 15:29:03 +0100 [thread overview]
Message-ID: <20081230142903.GA3449@adopmeer.homeip.net> (raw)
In-Reply-To: <200812300115.02408.dmitry.torokhov@gmail.com>
On Tue, Dec 30, 2008 at 01:15:01AM -0800, Dmitry Torokhov wrote:
> On Monday 29 December 2008 22:03:35 Alexander E. Patrakov wrote:
> >
> > This is still slightly wrong. The mouse does work, but is misnamed in
> > the dmesg output and in /proc/bus/input/devices:
> >
> > psmouse serio1: ID: 10 00 64<6>elantech.c: Elantech version query result
> > 0x00, 0x01, 0x64.
> > elantech.c: Probably not a real Elantech touchpad. Aborting.
> > input: ImExPS/2 Elantech Touchpad as /class/input/input8
>
> Yeah, elantech_init() is too late, we need to do something in
> elantech_detect()...
Well, we could also move that Elantech version query and test for sane
values into elantech_detect(). However, because we have no private data
structure at that time it would mean we have to do the same query again in
elantech_init() to store fw_version_maj and fw_version_min.
> Maybe we need to pull part of Logitech check (number of buttons for
> example) from logips2pp.c.
I think the solution above is simpler although maybe not as pretty... :)
Arjan
next prev parent reply other threads:[~2008-12-30 14:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <gj4r8h$okm$1@ger.gmane.org>
2008-12-28 6:21 ` 2.6.28 thinks that my PS/2 mouse is a touchpad Andrew Morton
2008-12-29 18:56 ` Arjan Opmeer
2008-12-30 6:03 ` Alexander E. Patrakov
2008-12-30 9:15 ` Dmitry Torokhov
2008-12-30 14:29 ` Arjan Opmeer [this message]
2009-01-02 0:07 ` Denys Vlasenko
2009-01-02 18:37 ` Arjan Opmeer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081230142903.GA3449@adopmeer.homeip.net \
--to=arjan@opmeer.net \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrakov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).