Re: Adding 'half shutter' definition to 'input.h'

Re: Adding 'half shutter' definition to 'input.h'

[Kim Kyuwon]

Hi, All

Because Jiri Kosina personally agrees with adding the [half]shutter
key yesterday,
I'm sending this patch. (Thanks Jiri)

New cameras and mobile phones (at least SAMSUNG's) have the half shutter for
'auto-focus' functions. so I think this half and full shutter keys are needed.

Please review this patch.
Thank you!

On Wed, Dec 24, 2008 at 9:31 AM, 김규원 <chammoru@gmail.com> wrote:
> Thanks for your reply ;)
>
> On Tue, Dec 23, 2008 at 5:45 PM, Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
>> Hi Kim,
>>
>> On Monday 22 December 2008 22:27:51 Kyu-Won Kim wrote:
>>> Hi Dmitry,
>>>
>>> We are making the camera application for mobile phone and our products have
>>> half shutter (the technical name of buttion is "Double-action
>>> Side-operation Type Light Touch Switch") as other general cameras.
>>> Datasheet is here:
>>> http://www.datasheetpro.com/205793_view_EVQQ0C03K_datasheet.html
>>>
>>> The problem is that there is no KEY definition for half shutter in input.h.
>>> I think KEY_CAMERA is the most related key but we need more definitions
>>> like KEY_CAMERA2, KEY_HALFSUTTER or KEY_FULLSHUTTER
>>>
>>> Could you give me your opinions about this half shutter
>>>
>>
>> Hmm, we certainly could add some more key definitions, but given that the
>> usage is very tightly coupled to the device and application I wonder if you
>> should simply use KEY_PROG* there...
>
> We can simply use KEY_PROG1, but state-of-the-art digital camera supports
> 'auto-focus' functions and therefore I think Half-Shutter key is a MUST. (I'm
> sure there are many digital cameras which use Linux as OS).
>
>>
>> Let's CC Jiri Kosina and see if he has any input on this matter.
>
> Can I ask Kosina's opinion, too?
>
>>
>> --
>> Dmitry
>>
>
>
> --
> Kim Kyuwon
>

commit a2f0629f9202433cd2b23b5c951dae66fd2b4f14
Author: Kim Kyuwon <kyuwonmoru.kim@samsung.com>
Date:   Thu Jan 8 11:08:43 2009 +0900

    Input: add definitions for camera full and half shutters
    Signed-off-by: Kim Kyuwon <kyuwonmoru.kim@samsung.com>

diff --git a/include/linux/input.h b/include/linux/input.h
index 9a6355f..41ed2fb 100644
--- a/include/linux/input.h
+++ b/include/linux/input.h
@@ -541,6 +541,9 @@ struct input_absinfo {
 #define KEY_CONTEXT_MENU	0x1b6	/* GenDesc - system context menu */
 #define KEY_MEDIA_REPEAT	0x1b7	/* Consumer - transport control */

+#define KEY_HALF_SHUTTER	0x1b8
+#define KEY_FULL_SHUTTER	0x1b9
+
 #define KEY_DEL_EOL		0x1c0
 #define KEY_DEL_EOS		0x1c1
 #define KEY_INS_LINE		0x1c2

-- 
Kim Kyuwon

Re: Adding 'half shutter' definition to 'input.h'

[Jiri Kosina]

On Thu, 8 Jan 2009, Kim Kyuwon wrote:

> Because Jiri Kosina personally agrees with adding the [half]shutter key 
> yesterday, I'm sending this patch. (Thanks Jiri)
> New cameras and mobile phones (at least SAMSUNG's) have the half shutter for
> 'auto-focus' functions. so I think this half and full shutter keys are needed.
> Please review this patch.

Hi,

please note the "if there is any in-kernel code that actually uses it" 
part of my e-mail. Adding just the key definition without any kernel code 
actually using is not likely to happen.

Thanks,

-- 
Jiri Kosina
SUSE Labs

Re: Adding 'half shutter' definition to 'input.h'

[Dmitry Torokhov]

Hi Kim, Jiri,

On Thu, Jan 08, 2009 at 09:51:11AM +0100, Jiri Kosina wrote:
> On Thu, 8 Jan 2009, Kim Kyuwon wrote:
> 
> > Because Jiri Kosina personally agrees with adding the [half]shutter key 
> > yesterday, I'm sending this patch. (Thanks Jiri)
> > New cameras and mobile phones (at least SAMSUNG's) have the half shutter for
> > 'auto-focus' functions. so I think this half and full shutter keys are needed.
> > Please review this patch.
> 
> Hi,
> 
> please note the "if there is any in-kernel code that actually uses it" 
> part of my e-mail. Adding just the key definition without any kernel code 
> actually using is not likely to happen.
> 

Additionally I don't think we need 2 new codes. We have KEY_CAMERA that
is supposed to be sent when we want to take the picture, so only one new
is needed. Probably should call it KEY_FOCUS or KEY_CAMERA_FOCUS.

-- 
Dmitry

Re: Adding 'half shutter' definition to 'input.h'

[Kim Kyuwon]

Hi, Dmitry,

On Sun, Jan 11, 2009 at 4:57 PM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> Hi Kim, Jiri,
>
> On Thu, Jan 08, 2009 at 09:51:11AM +0100, Jiri Kosina wrote:
>> On Thu, 8 Jan 2009, Kim Kyuwon wrote:
>>
>> > Because Jiri Kosina personally agrees with adding the [half]shutter key
>> > yesterday, I'm sending this patch. (Thanks Jiri)
>> > New cameras and mobile phones (at least SAMSUNG's) have the half shutter for
>> > 'auto-focus' functions. so I think this half and full shutter keys are needed.
>> > Please review this patch.
>>
>> Hi,
>>
>> please note the "if there is any in-kernel code that actually uses it"
>> part of my e-mail. Adding just the key definition without any kernel code
>> actually using is not likely to happen.
>>
>
> Additionally I don't think we need 2 new codes. We have KEY_CAMERA that
> is supposed to be sent when we want to take the picture, so only one new
> is needed. Probably should call it KEY_FOCUS or KEY_CAMERA_FOCUS.
>
> --
> Dmitry
>

OK, It seems like your suggestion is better mine :)
(Personally I prefer KEY_FOCUS to KEY_CAMERA_FOCUS )
And I would be really satisfied, if any key which can represent the half
shutter is added to 'input.h'

Thank you for thinking this issue again.
If there are further steps that I can take, please let me know.

-- 
Kim Kyuwon

Re: Adding 'half shutter' definition to 'input.h'

[Dmitry Torokhov]

Hi Kim,

On Mon, Jan 12, 2009 at 10:00:32AM +0900, Kim Kyuwon wrote:
> Hi, Dmitry,
> 
> On Sun, Jan 11, 2009 at 4:57 PM, Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> > Hi Kim, Jiri,
> >
> > On Thu, Jan 08, 2009 at 09:51:11AM +0100, Jiri Kosina wrote:
> >> On Thu, 8 Jan 2009, Kim Kyuwon wrote:
> >>
> >> > Because Jiri Kosina personally agrees with adding the [half]shutter key
> >> > yesterday, I'm sending this patch. (Thanks Jiri)
> >> > New cameras and mobile phones (at least SAMSUNG's) have the half shutter for
> >> > 'auto-focus' functions. so I think this half and full shutter keys are needed.
> >> > Please review this patch.
> >>
> >> Hi,
> >>
> >> please note the "if there is any in-kernel code that actually uses it"
> >> part of my e-mail. Adding just the key definition without any kernel code
> >> actually using is not likely to happen.
> >>
> >
> > Additionally I don't think we need 2 new codes. We have KEY_CAMERA that
> > is supposed to be sent when we want to take the picture, so only one new
> > is needed. Probably should call it KEY_FOCUS or KEY_CAMERA_FOCUS.
> >
> > --
> > Dmitry
> >
> 
> OK, It seems like your suggestion is better mine :)
> (Personally I prefer KEY_FOCUS to KEY_CAMERA_FOCUS )
> And I would be really satisfied, if any key which can represent the half
> shutter is added to 'input.h'
> 
> Thank you for thinking this issue again.
> If there are further steps that I can take, please let me know.
> 

Just add the key definition to input.h and send it along with the rest
of the driver when you feel that it is ready to be merged in mainline.

Thanks.

-- 
Dmitry