From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Arjan van de Ven <arjan@infradead.org>,
linux-input <linux-input@vger.kernel.org>
Subject: Re: [PATCH] input: input: stop autorepeat timer on key release
Date: Sun, 11 Jan 2009 23:36:01 -0800 [thread overview]
Message-ID: <20090111233431.ZZRA012@mailhub.coreip.homeip.net> (raw)
In-Reply-To: <1231241184.3684.1.camel@johannes>
Hi Johannes,
On Tue, Jan 06, 2009 at 12:26:24PM +0100, Johannes Berg wrote:
> Whenever you press and then release a key, the CPU wakes up
> three times:
> * press
> * release
> * autorepeat timer exactly 250ms after press
>
> The autorepeat timer has nothing to do, obviously, since you already
> have released the key, so stop it on key release.
>
This introduces a slight change in behaviour (the key that is released
may not be one that is being autorepeated) but I think it still makes
sense to do it.
--
Dmitry
next prev parent reply other threads:[~2009-01-12 7:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-06 11:26 [PATCH] input: input: stop autorepeat timer on key release Johannes Berg
2009-01-12 7:36 ` Dmitry Torokhov [this message]
2009-01-12 8:51 ` Johannes Berg
2009-01-13 5:02 ` Dmitry Torokhov
2009-01-13 8:56 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090111233431.ZZRA012@mailhub.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=arjan@infradead.org \
--cc=johannes@sipsolutions.net \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).