From: Carlos Corbacho <carlos@strangeworlds.co.uk>
To: Philipp Kohlbecher <xt28@gmx.de>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
rtc-linux@googlegroups.com, Vojtech Pavlik <vojtech@ucw.cz>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jiri Kosina <jkosina@suse.cz>,
linux-input@vger.kernel.org, Pau Oliva Fora <pof@eslack.org>,
Hans Verkuil <hverkuil@xs4all.nl>,
"David S. Miller" <davem@davemloft.net>,
Jaroslav Kysela <perex@perex.cz>, Adam Belay <abelay@mit.edu>,
Bjorn Helgaas <bjorn.helgaas@hp.com>, Len Brown <lenb@kernel.org>,
Jonathan Woithe <jwoithe@physics.adelaide.edu.au>,
linux-acpi@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Make PNP IDs all uppercase
Date: Thu, 22 Jan 2009 23:03:38 +0000 [thread overview]
Message-ID: <200901222303.41737.carlos@strangeworlds.co.uk> (raw)
In-Reply-To: <49733678.40006@gmx.de>
On Sunday 18 January 2009 14:02:32 Philipp Kohlbecher wrote:
> If I understand correctly, ACPI _HIDs (including PNP IDs) should be all
> uppercase, including the hex digits, cf. ACPI Specification 3.0b [1],
> pp. 162-3 and acpi_glb_hex_to_ascii[] in drivers/acpi/utilities/utglobal.c.
ACPI-WMI violates the spec here.
> diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c
> index 8a8b377..79b8af7 100644
> --- a/drivers/platform/x86/wmi.c
> +++ b/drivers/platform/x86/wmi.c
> @@ -84,7 +84,7 @@ static int acpi_wmi_add(struct acpi_device *device);
>
> static const struct acpi_device_id wmi_device_ids[] = {
> {"PNP0C14", 0},
> - {"pnp0c14", 0},
> + {"PNP0C14", 0},
> {"", 0},
> };
> MODULE_DEVICE_TABLE(acpi, wmi_device_ids);
> diff --git a/drivers/pnp/quirks.c b/drivers/pnp/quirks.c
> index 8473fe5..18c9335 100644
NAK to the ACPI-WMI changes. There really is a pnp0c14 and a PNP0C14, and
removing the lower case version breaks ACPI-WMI on my laptop.
-Carlos
--
E-Mail: carlos@strangeworlds.co.uk
Web: strangeworlds.co.uk
GPG Key ID: 0x23EE722D
next prev parent reply other threads:[~2009-01-22 23:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <49733678.40006@gmx.de>
2009-01-21 0:42 ` [PATCH] Make PNP IDs all uppercase Bjorn Helgaas
2009-01-21 7:56 ` Philipp Kohlbecher
2009-01-21 8:18 ` Alessandro Zummo
2009-01-21 17:09 ` Bjorn Helgaas
2009-01-21 17:30 ` Kay Sievers
2009-01-22 23:03 ` Carlos Corbacho [this message]
2009-01-18 14:02 Philipp Kohlbecher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901222303.41737.carlos@strangeworlds.co.uk \
--to=carlos@strangeworlds.co.uk \
--cc=a.zummo@towertech.it \
--cc=abelay@mit.edu \
--cc=bjorn.helgaas@hp.com \
--cc=davem@davemloft.net \
--cc=dmitry.torokhov@gmail.com \
--cc=hpa@zytor.com \
--cc=hverkuil@xs4all.nl \
--cc=jkosina@suse.cz \
--cc=jwoithe@physics.adelaide.edu.au \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=perex@perex.cz \
--cc=pof@eslack.org \
--cc=rtc-linux@googlegroups.com \
--cc=tglx@linutronix.de \
--cc=vojtech@ucw.cz \
--cc=xt28@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).