From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Subject: Re: [PATCH RFC] sh: maple: Add support for SEGA Dreamcast VMU and clean up maple bus driver (3/3) Date: Thu, 29 Jan 2009 00:46:05 -0500 Message-ID: <200901290046.07659.vapier@gentoo.org> References: <1233186456.6734.16.camel@localhost.localdomain> <1233187750.6734.27.camel@localhost.localdomain> <1233188287.6734.32.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1233188287.6734.32.camel@localhost.localdomain> Content-Disposition: inline Sender: linux-sh-owner@vger.kernel.org To: Adrian McMenamin Cc: Paul Mundt , Greg KH , Dmitry Torokhov , dwmw2 , linux-sh , LKML , linux-input , MTD List-Id: linux-input@vger.kernel.org On Wednesday 28 January 2009 19:18:07 Adrian McMenamin wrote: > --- a/drivers/input/keyboard/maple_keyb.c > +++ b/drivers/input/keyboard/maple_keyb.c > - if (!kbd || !idev) { > - error = -ENOMEM; > + if (!kbd) { > + error = ENOMEM; > goto fail; > } > ... > - return error; > +fail: > + return -error; this driver has the weird/broken error inverting other patches of yours have had recently ... that stuff really needs to stop showing up ;) -mike