From: Mike Frysinger <vapier@gentoo.org>
To: Adrian McMenamin <adrian@newgolddream.dyndns.info>
Cc: Paul Mundt <lethal@linux-sh.org>, Greg KH <greg@kroah.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
dwmw2 <dwmw2@infradead.org>, LKML <linux-kernel@vger.kernel.org>,
MTD <linux-mtd@lists.infradead.org>,
linux-sh <linux-sh@vger.kernel.org>,
linux-input <linux-input@vger.kernel.org>
Subject: Re: [PATCH] sh: maple: add support for Visual Memory Card devices, and make consequential changes to maple input drivers - 2/3 - v5
Date: Mon, 9 Feb 2009 19:11:43 -0500 [thread overview]
Message-ID: <200902091911.46383.vapier@gentoo.org> (raw)
In-Reply-To: <1234215716.6756.18.camel@localhost.localdomain>
On Monday 09 February 2009 16:41:56 Adrian McMenamin wrote:
> But the basic point here is that changing the bus code is necessary to
> get the VMU driver (or *any* VMU driver) to work, but changing the bus
> driver also breaks the two existing drivers in mainline that use the
> bus. The breakage in terms of lines to be fixed is small, but it still
> needs to be done 'all at once'.
the bus change and the resulting fallout in those drivers should be 1
changeset. if you want to do more work than just transitioning those drivers,
that should be additional patches that depend on that bus changeset. that way
bisection will not break as Paul highlighted.
-mike
next prev parent reply other threads:[~2009-02-10 0:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-08 19:41 [PATCH] sh: maple: add support for Visual Memory Card devices, and make consequential changes to maple input drivers - 0/3 - v5 Adrian McMenamin
2009-02-08 19:52 ` [PATCH] sh: maple: add support for Visual Memory Card devices, and make consequential changes to maple input drivers - 0/3 - v5 - diff stat correction Adrian McMenamin
2009-02-08 20:00 ` [PATCH] sh: maple: add support for Visual Memory Card devices, and make consequential changes to maple input drivers - 1/3 - v5 Adrian McMenamin
2009-02-08 20:04 ` [PATCH] sh: maple: add support for Visual Memory Card devices, and make consequential changes to maple input drivers - 2/3 " Adrian McMenamin
2009-02-09 6:56 ` Paul Mundt
2009-02-09 19:17 ` Adrian McMenamin
2009-02-09 19:33 ` Mike Frysinger
2009-02-09 21:41 ` Adrian McMenamin
2009-02-10 0:11 ` Mike Frysinger [this message]
2009-02-08 20:07 ` [PATCH] sh: maple: add support for Visual Memory Card devices, and make consequential changes to maple input drivers - 0/3 " Adrian McMenamin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902091911.46383.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=adrian@newgolddream.dyndns.info \
--cc=dmitry.torokhov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=greg@kroah.com \
--cc=lethal@linux-sh.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).