From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mundt Subject: Re: [PATCH] sh: maple: Update the maple bus driver to support block reads and writes Date: Fri, 27 Feb 2009 16:06:34 +0900 Message-ID: <20090227070634.GC28802@linux-sh.org> References: <1234641948.6609.13.camel@localhost.localdomain> <1234642605.6609.17.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from 124x34x33x190.ap124.ftth.ucom.ne.jp ([124.34.33.190]:35448 "EHLO master.linux-sh.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756563AbZB0HKS (ORCPT ); Fri, 27 Feb 2009 02:10:18 -0500 Content-Disposition: inline In-Reply-To: <1234642605.6609.17.camel@localhost.localdomain> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Adrian McMenamin Cc: Greg KH , Dmitry Torokhov , linux-input , linux-sh , LKML On Sat, Feb 14, 2009 at 08:16:45PM +0000, Adrian McMenamin wrote: > On Sat, 2009-02-14 at 20:06 +0000, Adrian McMenamin wrote: > > Greg, > > > > This patch updates the maple bus to support asynchronous block reads and > > writes as well as generally improving the quality of the code and > > supporting concurrency (all needed to support the Dreamcast visual > > memory unit - a driver will also be posted for that). > > > > I have posted versions of this before but am here following the patch > > grouping suggested and have also tested this code and unlike earlier > > versions it shows no signs of suffering from race conditions - so I hope > > you will be happy to queue it for inclusion. > > > > Changes in the bus driver necessitate some changes in the two maple bus > > input drivers that are currently in mainline. > > > > (Maple is SEGA's proprietary serial bus for the Dreamcast. It is capable > > of comm speeds of up to 2Mbs.) > > > > As well as supporting block reads and writes this code clean up removes > > some poor handling of locks, uses an atomic status variable to serialise > > access to devices and more robusly handles the general performance > > problems of the bus. > > > Apologies, some of the VMU patch slipped into that. Here is a completely > clean version. > > Signed-off-by: Adrian McMenamin Applied, thanks.