From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH] Input notifier support Date: Sat, 28 Feb 2009 19:07:45 -0800 Message-ID: <20090228190644.ZZRA012@mailhub.coreip.homeip.net> References: <20090225044730.GA9106@july> <87skly16gh.fsf@basil.nowhere.org> <20090228164126.ZZRA012@mailhub.coreip.homeip.net> <9c9fda240902281852n32b41cc7ref61dff7d5c1249f@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from an-out-0708.google.com ([209.85.132.244]:44357 "EHLO an-out-0708.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753471AbZCADH6 (ORCPT ); Sat, 28 Feb 2009 22:07:58 -0500 Content-Disposition: inline In-Reply-To: <9c9fda240902281852n32b41cc7ref61dff7d5c1249f@mail.gmail.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Kyungmin Park Cc: Andi Kleen , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org On Sun, Mar 01, 2009 at 11:52:56AM +0900, Kyungmin Park wrote: > On Sun, Mar 1, 2009 at 9:42 AM, Dmitry Torokhov > wrote: > > On Sun, Mar 01, 2009 at 12:34:38AM +0100, Andi Kleen wrote: > >> Kyungmin Park writes: > >> > >> > Some hardware doesn't connected with key button and led. In this case key should be connected with led by software. Of course each application can control it however it's too big burden to application programmer. > >> > > >> > So add input notifier and then use it at other frameworks such as led. > >> > Of course, other input device can use this one. > >> > > >> > Any commnets are welcome. > >> > >> It looks like the perfect interface for a password stealing root kit. > >> > >> Yes there are probably other ways to do this, but still this seems to > >> make it very easy. > >> > > > > We already have good interface for that. That's why you want to limit > > access to /dev/input/eventX ;) and not make it world-readable. > > > > Hi Dmitry, > > Could you tell me know which interface you're talking? > I agreed it's not good idea to pass key code value to drivers. it > caused security issues. > The interface to steal the root password. One can simply open all input devices and read all events (if the process has sufficient rights). -- Dmitry