Re: [PATCH 2/2] Input: add wm97xx accelerated driver for AVR32 AT32AP700X microprocessors

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

Hi Mark,

On Mon, Mar 02, 2009 at 01:23:48PM +0000, Mark Brown wrote:
> +
> +		if (!pressure && source == WM97XX_ADCSEL_Y) {
> +			input_report_abs(wm->input_dev, ABS_X, at32_wm97xx->x);
> +			input_report_abs(wm->input_dev, ABS_Y, at32_wm97xx->y);
> +			input_report_abs(wm->input_dev, ABS_PRESSURE, pen_down);

Please do not report pressure (and don't advertise ABS_PRESSURE) if you don't
actually read it. I have seen a follow-up patch that adds BTN_TOUCH that should
work just fine here. The usage below is good since there you actually do provide
true pressure readings. BTW, why would one not want pressure readings?

> +			input_sync(wm->input_dev);
> +		} else if (pressure && source == WM97XX_ADCSEL_PRES) {
> +			input_report_abs(wm->input_dev, ABS_X, at32_wm97xx->x);
> +			input_report_abs(wm->input_dev, ABS_Y, at32_wm97xx->y);
> +			input_report_abs(wm->input_dev, ABS_PRESSURE, value);
> +			input_sync(wm->input_dev);

Thanks.

-- 
Dmitry