linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Mack <daniel@caiaq.de>
To: hartleys <hartleys@visionengravers.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] generic driver for rotary encoders on GPIOs
Date: Sat, 7 Mar 2009 18:06:33 +0100	[thread overview]
Message-ID: <20090307170632.GA31096@buzzloop.caiaq.de> (raw)
In-Reply-To: <20090304172054.GD12183@buzzloop.caiaq.de>

On Wed, Mar 04, 2009 at 06:20:54PM +0100, Daniel Mack wrote:
> > 2) I have a patch to the driver that allows the axis to be a REL_* type.
> > I will post this patch for review after the driver is committed.
> 
> Cool, that might be a good alternative for users.
> 
> > 3) Are both 'inverted_*' flags really needed?  It appears that the end
> > effect of these just reverses the logical direction of the encoder.
> > 
> > 	inverted_a	inverted_b	result
> > 	0		0		normal encoder
> > 	0		1		backwards encoder
> > 	1		0		backwards encoder
> > 	1		1		normal encoder

The driver has now been commited to input.git/next, so you could send a
patch with your ideas on top of it if you like and find some time :)

Daniel


  reply	other threads:[~2009-03-07 17:06 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-26 18:00 [PATCH] generic driver for rotary encoders on GPIOs Daniel Mack
2009-02-26 18:42 ` Daniel Mack
2009-02-27  3:18   ` hartleys
2009-02-27  6:43     ` Daniel Mack
2009-02-27  8:48       ` Daniel Mack
2009-02-27 17:13       ` hartleys
2009-02-27 17:17         ` Daniel Mack
2009-02-27 18:00       ` Daniel Mack
2009-02-27 18:30         ` hartleys
2009-02-27 18:34           ` Daniel Mack
2009-02-27 20:15             ` hartleys
2009-03-02 14:43               ` Daniel Mack
2009-03-03  8:52                 ` Dmitry Torokhov
2009-03-03  9:03                   ` Dmitry Torokhov
2009-03-03  9:59                     ` Daniel Mack
2009-03-04  8:48                       ` Dmitry Torokhov
2009-03-04  9:50                         ` Daniel Mack
2009-03-04 17:02                           ` hartleys
2009-03-04 17:20                             ` Daniel Mack
2009-03-07 17:06                               ` Daniel Mack [this message]
2009-04-13 23:06                                 ` [PATCH] add REL_* axes support to the rotary encoder driver H Hartley Sweeten
2009-04-14  5:50                                   ` Daniel Mack
2009-04-14 15:33                                     ` H Hartley Sweeten
2009-04-16  2:08                                   ` Dmitry Torokhov
2009-04-16  2:24                                     ` H Hartley Sweeten
2009-04-16  2:33                                       ` Dmitry Torokhov
2009-04-16  3:11                                         ` H Hartley Sweeten
2009-04-16  6:35                                           ` Daniel Mack
2009-04-16  8:05                                           ` Daniel Mack
2009-04-16 16:48                                             ` H Hartley Sweeten
2009-04-16  8:39                                           ` Daniel Mack
2009-04-16 17:09                                             ` H Hartley Sweeten

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090307170632.GA31096@buzzloop.caiaq.de \
    --to=daniel@caiaq.de \
    --cc=hartleys@visionengravers.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).