From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Matthew Garrett <mjg@redhat.com>
Cc: Richard Hughes <hughsient@gmail.com>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
linux-acpi <linux-acpi@vger.kernel.org>,
Peter Hutterer <peter.hutterer@redhat.com>,
linux-input <linux-input@vger.kernel.org>,
Matthias Clasen <mclasen@redhat.com>
Subject: Re: suspend / hibernate nomenclature
Date: Sun, 8 Mar 2009 21:56:45 +0100 [thread overview]
Message-ID: <200903082156.46219.rjw@sisk.pl> (raw)
In-Reply-To: <20090308144145.GB26233@srcf.ucam.org>
On Sunday 08 March 2009, Matthew Garrett wrote:
> On Sun, Mar 08, 2009 at 08:45:59AM +0000, Richard Hughes wrote:
> > On Sat, Mar 7, 2009 at 8:39 PM, Matthew Garrett <mjg@redhat.com> wrote:
> > > We don't have to at all - as far as I've been able to tell, the kernel
> > > is utterly consistent in its current usage. The only drivers that emit
> > > KEY_SLEEP are either embedded-specific (where it's clearly suspend to
> > > RAM and not hibernate), the ACPI driver (where usage in other operating
> > > systems is consistent with it being suspent to RAM) and the panasonic
> > > and thinkpad drivers which use it consistently. If there's any
> > > confusion, it's over the fact that KEY_SUSPEND is is used for suspend to
> > > RAM in a (smaller) number of places.
> >
> > The fact that we're mapping x->y and y->x is the reason people keep
> > getting it wrong.
>
> Sure, doing things differently would have made sense several years ago
> when nobody was relying on this behaviour. We don't have that option now
> - making this change will break things, and we've got no idea how much
> it'll break.
Which is a good enough reason to avoid it.
Alternatively, we can add completely new definitions _along_ _with_ the old
ones, mark the old ones as obsolete (after some time) and try to make the
user space start using the new ones only (that may be difficult, though).
I said I liked the names, but I didn't realize that changing them would break
things.
Thanks,
Rafael
next prev parent reply other threads:[~2009-03-08 20:56 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-02 11:13 suspend / hibernate nomenclature Richard Hughes
2009-03-02 11:24 ` Henrique de Moraes Holschuh
2009-03-02 12:11 ` Richard Hughes
2009-03-03 17:20 ` [patch] add KEY_HIBERNATE and clarify the uses of KEY_SUSPEND and KEY_SLEEP Richard Hughes
2009-03-03 19:53 ` Rafael J. Wysocki
2009-03-04 8:42 ` Dmitry Torokhov
2009-03-04 10:54 ` [PATCH] thinkpad-acpi: use correct key names for sleep states in driver Richard Hughes
2009-03-04 10:58 ` [PATCH] panasonic-laptop: " Richard Hughes
2009-03-04 23:58 ` Harald Welte
2009-03-05 9:09 ` Richard Hughes
2009-03-04 11:09 ` [PATCH] DVB-USB: correct the comment about KEY_SLEEP Richard Hughes
2009-03-10 10:31 ` Antti Palosaari
2009-03-04 12:04 ` [PATCH] thinkpad-acpi: use correct key names for sleep states in driver Henrique de Moraes Holschuh
2009-08-18 20:02 ` Yves-Alexis Perez
2009-08-18 20:10 ` Matthew Garrett
2009-08-18 20:27 ` Yves-Alexis Perez
2009-08-18 20:45 ` Matthew Garrett
2009-08-22 18:02 ` Henrique de Moraes Holschuh
2009-08-19 9:18 ` Ali Abdallah
2009-08-26 11:36 ` Yves-Alexis Perez
2009-08-26 13:43 ` Matthew Garrett
2009-08-26 17:52 ` Yves-Alexis Perez
2009-08-26 22:51 ` Henrique de Moraes Holschuh
2009-08-27 6:18 ` Dmitry Torokhov
2009-08-28 0:34 ` Henrique de Moraes Holschuh
2009-03-07 8:37 ` suspend / hibernate nomenclature Andrey Borzenkov
2009-03-07 15:48 ` Matthew Garrett
2009-03-07 16:41 ` Henrique de Moraes Holschuh
2009-03-07 16:48 ` Matthew Garrett
2009-03-07 17:17 ` Henrique de Moraes Holschuh
2009-03-07 20:25 ` Richard Hughes
2009-03-07 20:39 ` Matthew Garrett
2009-03-08 8:45 ` Richard Hughes
2009-03-08 14:41 ` Matthew Garrett
2009-03-08 20:56 ` Rafael J. Wysocki [this message]
2009-03-08 23:07 ` Dmitry Torokhov
2009-03-08 23:19 ` Matthew Garrett
2009-03-09 13:52 ` Ville Syrjälä
2009-03-09 14:00 ` Matthew Garrett
2009-03-09 15:10 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903082156.46219.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=hmh@hmh.eng.br \
--cc=hughsient@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=mclasen@redhat.com \
--cc=mjg@redhat.com \
--cc=peter.hutterer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).