From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Eric Dumazet <dada1@cosmosbay.com>,
dipankar@in.ibm.com, linux-input@vger.kernel.org,
dmitry.torokhov@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: Question about usage of RCU in the input layer
Date: Sun, 22 Mar 2009 09:53:24 -0700 [thread overview]
Message-ID: <20090322165324.GH7148@linux.vnet.ibm.com> (raw)
In-Reply-To: <20090321225318.5b25f0a7@infradead.org>
On Sat, Mar 21, 2009 at 10:53:18PM -0700, Arjan van de Ven wrote:
> On Sat, 21 Mar 2009 22:18:22 -0700
> "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> wrote:
>
> > > I'm measuring the time that the following code takes:
> > >
> > > init_completion(&rcu.completion);
> > > /* Will wake me after RCU finished. */
> > > call_rcu(&rcu.head, wakeme_after_rcu);
> > > /* Wait for it. */
> > > wait_for_completion(&rcu.completion);
> > >
>
> >
> > No, my confusion -- I misread as 2700 milliseconds rather than 2700
> > -microseconds-. 2700 microseconds (or 2.7 milliseconds) is in the
> > expected range for synchronize_rcu() on an HZ=1000 system. 2.7
> > seconds would of course be way out of line.
>
> > > > If the former, exactly which kernel are you using? The single-CPU
> > > > optimization was added in 2.6.29-rc7, commit ID a682604838.
> > >
> > > a bit after -rc8, specifically commit
> > > 5bee17f18b595937e6beafeee5197868a3f74a06
> >
> > How many synchronize_rcu() calls are you seeing on the boot path?
>
> I see 20 that hit the above code path (eg ones that wait) until
> userspace starts.
So with well-behaved readers, the full sequence would be worth
something like 50-60 milliseconds.
> > Also, are you running with NO_HZ=y?
>
> of course... is there any other way ? ;-)
Well, if it does become necessary to make common-case no-readers
execution of synchronize_rcu() go faster, you certainly have made the
correct choice. ;-)
Thanx, Paul
next prev parent reply other threads:[~2009-03-22 16:53 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-19 4:58 Question about usage of RCU in the input layer Arjan van de Ven
2009-03-19 7:23 ` Dmitry Torokhov
2009-03-19 14:02 ` Arjan van de Ven
2009-03-19 8:56 ` Dipankar Sarma
2009-03-19 14:18 ` Arjan van de Ven
2009-03-20 2:07 ` Paul E. McKenney
2009-03-20 3:20 ` Arjan van de Ven
2009-03-20 4:45 ` Paul E. McKenney
2009-03-20 5:28 ` Eric Dumazet
2009-03-20 6:01 ` Dipankar Sarma
2009-03-20 6:35 ` Eric Dumazet
2009-03-20 13:50 ` Arjan van de Ven
2009-03-20 14:31 ` Paul E. McKenney
2009-03-20 18:13 ` Arjan van de Ven
2009-03-21 1:27 ` Paul E. McKenney
2009-03-21 4:58 ` Arjan van de Ven
2009-03-21 18:58 ` Paul E. McKenney
2009-03-21 19:51 ` Arjan van de Ven
2009-03-21 20:26 ` Eric Dumazet
2009-03-21 21:07 ` Paul E. McKenney
2009-03-22 3:40 ` Arjan van de Ven
2009-03-22 4:38 ` Paul E. McKenney
2009-03-22 4:51 ` Arjan van de Ven
2009-03-22 5:18 ` Paul E. McKenney
2009-03-22 5:53 ` Arjan van de Ven
2009-03-22 16:53 ` Paul E. McKenney [this message]
2009-03-22 19:46 ` Arjan van de Ven
2009-03-22 20:52 ` Paul E. McKenney
2009-03-22 22:44 ` Arjan van de Ven
2009-03-22 23:03 ` Paul E. McKenney
2009-03-22 23:16 ` Arjan van de Ven
2009-03-23 1:27 ` Paul E. McKenney
2009-04-03 1:27 ` Paul E. McKenney
2009-03-21 21:13 ` Arjan van de Ven
2009-03-20 22:21 ` Paul E. McKenney
2009-03-21 5:46 ` Dmitry Torokhov
2009-03-21 9:13 ` Eric Dumazet
2009-03-21 18:58 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090322165324.GH7148@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=arjan@infradead.org \
--cc=dada1@cosmosbay.com \
--cc=dipankar@in.ibm.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).