* [PATCH 1/1] INPUT: mainstone-wm97xx, fix condition in pen_up
@ 2009-04-15 6:43 Jiri Slaby
2009-04-15 12:00 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Jiri Slaby @ 2009-04-15 6:43 UTC (permalink / raw)
To: dmitry.torokhov
Cc: linux-input, linux-kernel, Jiri Slaby, Mark Brown, Liam Girdwood
The loop body was never executed, because the condition is
always false. Convert to for with more obvious condition.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>
---
drivers/input/touchscreen/mainstone-wm97xx.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/input/touchscreen/mainstone-wm97xx.c b/drivers/input/touchscreen/mainstone-wm97xx.c
index dfa6a84..4cc047a 100644
--- a/drivers/input/touchscreen/mainstone-wm97xx.c
+++ b/drivers/input/touchscreen/mainstone-wm97xx.c
@@ -111,13 +111,12 @@ static void wm97xx_acc_pen_up(struct wm97xx *wm)
#else
static void wm97xx_acc_pen_up(struct wm97xx *wm)
{
- int count = 16;
+ unsigned int count;
+
schedule_timeout_uninterruptible(1);
- while (count < 16) {
+ for (count = 0; count < 16; count++)
MODR;
- count--;
- }
}
#endif
--
1.6.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] INPUT: mainstone-wm97xx, fix condition in pen_up
2009-04-15 6:43 [PATCH 1/1] INPUT: mainstone-wm97xx, fix condition in pen_up Jiri Slaby
@ 2009-04-15 12:00 ` Mark Brown
2009-04-15 15:35 ` Dmitry Torokhov
0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2009-04-15 12:00 UTC (permalink / raw)
To: Jiri Slaby; +Cc: dmitry.torokhov, linux-input, linux-kernel, Liam Girdwood
On Wed, Apr 15, 2009 at 08:43:50AM +0200, Jiri Slaby wrote:
> The loop body was never executed, because the condition is
> always false. Convert to for with more obvious condition.
> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] INPUT: mainstone-wm97xx, fix condition in pen_up
2009-04-15 12:00 ` Mark Brown
@ 2009-04-15 15:35 ` Dmitry Torokhov
0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2009-04-15 15:35 UTC (permalink / raw)
To: Mark Brown; +Cc: Jiri Slaby, linux-input, linux-kernel, Liam Girdwood
On Wed, Apr 15, 2009 at 01:00:32PM +0100, Mark Brown wrote
> On Wed, Apr 15, 2009 at 08:43:50AM +0200, Jiri Slaby wrote:
> > The loop body was never executed, because the condition is
> > always false. Convert to for with more obvious condition.
>
> > Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
>
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Applied, thanks Jiri.
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-04-15 15:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-15 6:43 [PATCH 1/1] INPUT: mainstone-wm97xx, fix condition in pen_up Jiri Slaby
2009-04-15 12:00 ` Mark Brown
2009-04-15 15:35 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).