From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Ben Nizette <bn@niasdigital.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
dan.j.williams@intel.com, Eric Miao <eric.miao@marvell.com>,
linux@arm.linux.org.uk, p_gortmaker@yahoo.com,
David Brownell <david-b@pacbell.net>,
sameo@linux.intel.com, linux-omap@vger.kernel.org,
pierre@ossman.eu, linux-input@vger.kernel.org
Subject: Re: [PATCH 0/9] Fix unsafe disable_irq usage
Date: Sat, 18 Apr 2009 16:38:30 -0700 [thread overview]
Message-ID: <200904181638.30794.dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <1239861245.29831.113.camel@linux-51e8.site>
Hi Ben,
On Wednesday 15 April 2009 22:54:05 Ben Nizette wrote:
> After being bitten by unsafe usage of disable_irq from within that irq's
> handler [1], I went through and used Coccinelle to audit the rest of
> drivers/ too. This turned up 9 more unsafe usages.
>
> As Haavard pointed out in that thread, disable_irq waits for running
> handlers of an irq to complete before returning. When a handler
> disable_irq's its own irq then we see a deadlock.
>
> Note that this wasn't actually observed in the wild until the recent
> merge of
>
> commit 3aa551c9b4c40018f0e261a178e3d25478dc04a9
> Author: Thomas Gleixner <tglx@linutronix.de>
> Date: Mon Mar 23 18:28:15 2009 +0100
>
> genirq: add threaded interrupt handler support
>
> Add support for threaded interrupt handlers
>
>
Applied all 4 patches affecting input devices, they should show up next
time Linus pulls from me. Thank you.
--
Dmitry
prev parent reply other threads:[~2009-04-18 23:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-16 5:54 [PATCH 0/9] Fix unsafe disable_irq usage Ben Nizette
2009-04-18 23:38 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904181638.30794.dmitry.torokhov@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=bn@niasdigital.com \
--cc=dan.j.williams@intel.com \
--cc=david-b@pacbell.net \
--cc=eric.miao@marvell.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=p_gortmaker@yahoo.com \
--cc=pierre@ossman.eu \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).