Rawmode keyboard for your....

Rawmode keyboard for your....

[Kristoffer Ericson]

[-- Attachment #1: Type: text/plain, Size: 522 bytes --]

Greetings,

What exactly does this build warning imply?
We have a fully working keyboard driver for the Jornada 700-series
and would really like to get rid of this.


  CC      drivers/char/keyboard.o
drivers/char/keyboard.c:1126:2: warning: #warning "Cannot generate rawmode keyboard for your architecture yet."
drivers/char/keyboard.c:1126:2: warning: #warning "Cannot generate rawmode keyboard for your architecture yet."

Best wishes
Kristoffer


-- 
Kristoffer Ericson <kristoffer.ericson@gmail.com>

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

RE: Rawmode keyboard for your....

[H Hartley Sweeten]

On Thursday, March 26, 2009 10:59 AM, Kristoffer Ericson wrote:
> Greetings,

Hello

> What exactly does this build warning imply?
> We have a fully working keyboard driver for the Jornada 700-series
> and would really like to get rid of this.
>
>
>  CC      drivers/char/keyboard.o
> drivers/char/keyboard.c:1126:2: warning: #warning "Cannot generate
rawmode keyboard for your architecture yet."
> drivers/char/keyboard.c:1126:2: warning: #warning "Cannot generate
rawmode keyboard for your architecture yet."

It means just what it says, if you put the keyboard into VC_RAW mode you
will not get the expected key codes.

But... Hmm... Jornada 700-series is arm/mach-sa1100 (CONFIG_ARM)...

Looks like if you enable CONFIG_KEYBOARD_ATKBD the build warning message
will go away. 

Just my 2 cents...
Hartley

Re: Rawmode keyboard for your....

[Dmitry Torokhov]

On Thursday 26 March 2009 11:30:43 H Hartley Sweeten wrote:
> On Thursday, March 26, 2009 10:59 AM, Kristoffer Ericson wrote:
> > Greetings,
>
> Hello
>
> > What exactly does this build warning imply?
> > We have a fully working keyboard driver for the Jornada 700-series
> > and would really like to get rid of this.
> >
> >
> >  CC      drivers/char/keyboard.o
> > drivers/char/keyboard.c:1126:2: warning: #warning "Cannot generate
>
> rawmode keyboard for your architecture yet."
>
> > drivers/char/keyboard.c:1126:2: warning: #warning "Cannot generate
>
> rawmode keyboard for your architecture yet."
>
> It means just what it says, if you put the keyboard into VC_RAW mode you
> will not get the expected key codes.
>
> But... Hmm... Jornada 700-series is arm/mach-sa1100 (CONFIG_ARM)...
>
> Looks like if you enable CONFIG_KEYBOARD_ATKBD the build warning message
> will go away.
>

I think we should just remove the warning. It does not make much sense
anymore. I intend to apply the patch below.

-- 
Dmitry

Input: keyboard - remove warning about raw mode not supported

This warning made sense when legacy keyboard driver was preferred
driver in X, but now that evdev driver is the default we can remove
the warning.

Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
---

 drivers/char/keyboard.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)


diff --git a/drivers/char/keyboard.c b/drivers/char/keyboard.c
index de26a97..737be95 100644
--- a/drivers/char/keyboard.c
+++ b/drivers/char/keyboard.c
@@ -1123,8 +1123,6 @@ static int emulate_raw(struct vc_data *vc, unsigned int 
keycode,
 
 #define HW_RAW(dev)	0
 
-#warning "Cannot generate rawmode keyboard for your architecture yet."
-
 static int emulate_raw(struct vc_data *vc, unsigned int keycode, unsigned 
char up_flag)
 {
 	if (keycode > 127)

Re: Rawmode keyboard for your....

[Kristoffer Ericson]

On Mon, 20 Apr 2009 00:04:49 -0700
Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:

> On Thursday 26 March 2009 11:30:43 H Hartley Sweeten wrote:
> > On Thursday, March 26, 2009 10:59 AM, Kristoffer Ericson wrote:
> > > Greetings,
> >
> > Hello
> >
> > > What exactly does this build warning imply?
> > > We have a fully working keyboard driver for the Jornada 700-series
> > > and would really like to get rid of this.
> > >
> > >
> > >  CC      drivers/char/keyboard.o
> > > drivers/char/keyboard.c:1126:2: warning: #warning "Cannot generate
> >
> > rawmode keyboard for your architecture yet."
> >
> > > drivers/char/keyboard.c:1126:2: warning: #warning "Cannot generate
> >
> > rawmode keyboard for your architecture yet."
> >
> > It means just what it says, if you put the keyboard into VC_RAW mode you
> > will not get the expected key codes.
> >
> > But... Hmm... Jornada 700-series is arm/mach-sa1100 (CONFIG_ARM)...
> >
> > Looks like if you enable CONFIG_KEYBOARD_ATKBD the build warning message
> > will go away.
> >
> 
> I think we should just remove the warning. It does not make much sense
> anymore. I intend to apply the patch below.

Sounds like a good idea. Thanks!

> 
> -- 
> Dmitry
> 
> Input: keyboard - remove warning about raw mode not supported
> 
> This warning made sense when legacy keyboard driver was preferred
> driver in X, but now that evdev driver is the default we can remove
> the warning.
> 
> Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
> ---
> 
>  drivers/char/keyboard.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> 
> diff --git a/drivers/char/keyboard.c b/drivers/char/keyboard.c
> index de26a97..737be95 100644
> --- a/drivers/char/keyboard.c
> +++ b/drivers/char/keyboard.c
> @@ -1123,8 +1123,6 @@ static int emulate_raw(struct vc_data *vc, unsigned int 
> keycode,
>  
>  #define HW_RAW(dev)	0
>  
> -#warning "Cannot generate rawmode keyboard for your architecture yet."
> -
>  static int emulate_raw(struct vc_data *vc, unsigned int keycode, unsigned 
> char up_flag)
>  {
>  	if (keycode > 127)
> 
> 
> 


-- 
Kristoffer Ericson <kristoffer.ericson@gmail.com>