From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Ben Dooks <ben-linux-arm@fluff.org>,
linux-arm-kernel@lists.arm.linux.org.uk,
linux-input@vger.kernel.org
Subject: Re: [PATCH 3/5] [ARM] pxa: lx: add keyboard driver
Date: Mon, 20 Apr 2009 11:56:07 +0100 [thread overview]
Message-ID: <20090420105607.GB3653@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <200904200204.12612.dmitry.torokhov@gmail.com>
On Mon, Apr 20, 2009 at 02:04:12AM -0700, Dmitry Torokhov wrote:
> On Monday 20 April 2009 01:25:13 Russell King - ARM Linux wrote:
> > On Sat, Apr 18, 2009 at 04:10:28PM -0700, Dmitry Torokhov wrote:
> > > Hi Russell,
> > >
> > > On Sat, Apr 18, 2009 at 03:20:50PM +0100, Russell King wrote:
> > > > +static int __init lx_keyb_init(void)
> > > > +{
> > > > + printk(KERN_INFO "LX Keyboard Driver, (c) 2004 Simtec
> > > > Electronics\n");
> > >
> > > Is this needed? Input core will already add printk when input device is
> > > added and our boot is already chatty enough...
> >
> > Simtec themselves would need to remove that line.
>
> Umm, why? We not removing copyright notice from the file, just the
> message...
Because it's polite to at least ask them. I'm just the third party in
this (although I've already done substantial cleaning up of this code.)
They've agreed to remove the line, so it's now gone.
next prev parent reply other threads:[~2009-04-20 10:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-18 14:19 [PATCH 0/5] PXA LX platform support Russell King - ARM Linux
2009-04-18 14:20 ` [PATCH 3/5] [ARM] pxa: lx: add keyboard driver Russell King
2009-04-18 23:10 ` Dmitry Torokhov
2009-04-20 8:25 ` Russell King - ARM Linux
2009-04-20 9:04 ` Dmitry Torokhov
2009-04-20 10:56 ` Russell King - ARM Linux [this message]
2009-04-20 11:06 ` Russell King - ARM Linux
2009-04-20 11:13 ` [PATCH 3/5 UPDATED] " Russell King - ARM Linux
2009-04-21 2:16 ` Dmitry Torokhov
2009-04-22 18:56 ` Russell King - ARM Linux
2009-04-21 2:15 ` [PATCH 3/5] " Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090420105607.GB3653@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=ben-linux-arm@fluff.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).