From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kristoffer Ericson Subject: Re: Rawmode keyboard for your.... Date: Mon, 20 Apr 2009 13:04:30 +0200 Message-ID: <20090420130430.cf95a039.kristoffer.ericson@gmail.com> References: <20090326185925.79ca6833.kristoffer.ericson@gmail.com> <200904200004.49651.dmitry.torokhov@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from fk-out-0910.google.com ([209.85.128.189]:15754 "EHLO fk-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753773AbZDTLAI (ORCPT ); Mon, 20 Apr 2009 07:00:08 -0400 Received: by fk-out-0910.google.com with SMTP id 18so866003fkq.5 for ; Mon, 20 Apr 2009 04:00:06 -0700 (PDT) In-Reply-To: <200904200004.49651.dmitry.torokhov@gmail.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dmitry Torokhov Cc: H Hartley Sweeten , linux-input@vger.kernel.org On Mon, 20 Apr 2009 00:04:49 -0700 Dmitry Torokhov wrote: > On Thursday 26 March 2009 11:30:43 H Hartley Sweeten wrote: > > On Thursday, March 26, 2009 10:59 AM, Kristoffer Ericson wrote: > > > Greetings, > > > > Hello > > > > > What exactly does this build warning imply? > > > We have a fully working keyboard driver for the Jornada 700-series > > > and would really like to get rid of this. > > > > > > > > > CC drivers/char/keyboard.o > > > drivers/char/keyboard.c:1126:2: warning: #warning "Cannot generate > > > > rawmode keyboard for your architecture yet." > > > > > drivers/char/keyboard.c:1126:2: warning: #warning "Cannot generate > > > > rawmode keyboard for your architecture yet." > > > > It means just what it says, if you put the keyboard into VC_RAW mode you > > will not get the expected key codes. > > > > But... Hmm... Jornada 700-series is arm/mach-sa1100 (CONFIG_ARM)... > > > > Looks like if you enable CONFIG_KEYBOARD_ATKBD the build warning message > > will go away. > > > > I think we should just remove the warning. It does not make much sense > anymore. I intend to apply the patch below. Sounds like a good idea. Thanks! > > -- > Dmitry > > Input: keyboard - remove warning about raw mode not supported > > This warning made sense when legacy keyboard driver was preferred > driver in X, but now that evdev driver is the default we can remove > the warning. > > Signed-off-by: Dmitry Torokhov > --- > > drivers/char/keyboard.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > > diff --git a/drivers/char/keyboard.c b/drivers/char/keyboard.c > index de26a97..737be95 100644 > --- a/drivers/char/keyboard.c > +++ b/drivers/char/keyboard.c > @@ -1123,8 +1123,6 @@ static int emulate_raw(struct vc_data *vc, unsigned int > keycode, > > #define HW_RAW(dev) 0 > > -#warning "Cannot generate rawmode keyboard for your architecture yet." > - > static int emulate_raw(struct vc_data *vc, unsigned int keycode, unsigned > char up_flag) > { > if (keycode > 127) > > > -- Kristoffer Ericson