From: Greg KH <greg@kroah.com>
To: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
gregkh@suse.de, kay.sievers@vrfy.org
Subject: Re: [PATCH 0/4] fix some improper uses of dev_set_name
Date: Tue, 21 Apr 2009 22:45:31 -0700 [thread overview]
Message-ID: <20090422054531.GD9009@kroah.com> (raw)
In-Reply-To: <1240273036-5995-1-git-send-email-cascardo@holoscopio.com>
On Mon, Apr 20, 2009 at 09:17:12PM -0300, Thadeu Lima de Souza Cascardo wrote:
> dev_set_name expects a format string. Many of its uses, however, blindly
> call it with a string variable that comes from some external, perhaps
> unreliable source. Some of those uses are safe, like those in the third
> patch in the series and most of those not fixed by any of them. Some few
> remaining uses may require some more attention to decide if a patch is
> really required. Perhaps converting all of them for safeness is a good
> compromise.
>
> Thadeu Lima de Souza Cascardo (4):
> driver core: use string format when name is another device's name
> driver core: use string format when name is given to an exported
> function
These two patches were a bit more than just the "driver core". Care to
split them up into the subsystem-proper sections and send them to the
different subsystem maintainers?
I don't see anything here that can come from a user supplied string, do
you? So it's a pretty low priority.
thanks,
greg k-h
next prev parent reply other threads:[~2009-04-22 6:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-21 0:17 [PATCH 0/4] fix some improper uses of dev_set_name Thadeu Lima de Souza Cascardo
[not found] ` <cover.1240272928.git.cascardo@holoscopio.com>
2009-04-21 0:17 ` [PATCH 1/4] driver core: use string format when name is another device's name Thadeu Lima de Souza Cascardo
2009-04-21 0:17 ` [PATCH 2/4] driver core: use string format when name is given to an exported function Thadeu Lima de Souza Cascardo
2009-04-21 0:17 ` [PATCH 3/4] input: set the device's name and copy it to private version Thadeu Lima de Souza Cascardo
2009-04-21 0:17 ` [PATCH 4/4] ARM: use put_device instead of kfree Thadeu Lima de Souza Cascardo
2009-04-22 5:45 ` Greg KH [this message]
2009-04-22 21:06 ` [PATCH 0/4] fix some improper uses of dev_set_name Thadeu Lima de Souza Cascardo
2009-05-11 1:09 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090422054531.GD9009@kroah.com \
--to=greg@kroah.com \
--cc=cascardo@holoscopio.com \
--cc=gregkh@suse.de \
--cc=kay.sievers@vrfy.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).