Re: [PATCH] Input: synaptics - add support for reporting x/y resolution

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Thu, May 07, 2009 at 09:59:36PM +0300, Tero Saarni wrote:
> On Thu, May 7, 2009 at 19:49, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> >> +#define ABS_RESX                0x26
> >> +#define ABS_RESY                0x27
> >
> > This data is not part of dynamic state of the device but rather
> > describes it's physical characteristics and as such should not be
> > transmitted as input events. We should consider extending input_absinfo
> > and making this data available via EVIOCGABS ioctl but we need to be
> > careful with keeping compatibility with existing clients.
> 
> Thanks for your reply!
> 
> What kind of extension do you mean?
> 
> Making it available via EVIOCGABS ioctl was my intention too but
> extending by adding new ABS_nnn was the only obvious way I came up
> with.  All the other similar uses of input_absinfo seem to describe
> static limits of dynamic parameters (like max and min y coordinates)
> so I agree that resolution is not a perfect fit into the group,  For
> resolution I never need to call input_report_abs().
> 

Well, we could add '__u32 resolution;' field to struct input_absinfo but
we need to be really careful not to break applications using old
(smaller) structures with newer kernels.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html