linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Mack <daniel@caiaq.de>
To: Jean Delvare <khali@linux-fr.org>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] input: add driver for EETI touchpanels [v4]
Date: Sat, 16 May 2009 19:32:26 +0200	[thread overview]
Message-ID: <20090516173226.GA1448@buzzloop.caiaq.de> (raw)
In-Reply-To: <20090516175716.7dc22580@hyperion.delvare>

Hi Jean,

thanks for your input.

On Sat, May 16, 2009 at 05:57:16PM +0200, Jean Delvare wrote:
> > +	struct i2c_adapter *adapter = to_i2c_adapter(client->dev.parent);
> > +	struct eeti_ts_priv *priv;
> > +	struct input_dev *input;
> > +	int err = -ENOMEM;
> > +
> > +	if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE))
> 
> This functionality does not correspond to the I2C access method your
> code uses. You must check for I2C_FUNC_I2C instead (if you want to
> check at all - it's essentially optional with the new binding model.)

Yes, I though so too and removed the check for now.
New version coming up.

Thanks,
Daniel


  reply	other threads:[~2009-05-16 17:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-16  9:27 [PATCH] input: add driver for EETI touchpanels [v4] Daniel Mack
2009-05-16 15:57 ` Jean Delvare
2009-05-16 17:32   ` Daniel Mack [this message]
2009-05-16 17:34     ` [PATCH] input: add driver for EETI touchpanels [v5] Daniel Mack
2009-05-16 18:57       ` Jean Delvare
2009-05-19  9:01         ` Daniel Mack
2009-05-20  2:30           ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090516173226.GA1448@buzzloop.caiaq.de \
    --to=daniel@caiaq.de \
    --cc=khali@linux-fr.org \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).