From: Alek Du <alek.du@intel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input <linux-input@vger.kernel.org>
Subject: [PATCH] INPUT: Give more precise auto repeat control for gpio_keys driver
Date: Thu, 11 Jun 2009 20:07:54 +0800 [thread overview]
Message-ID: <20090611200754.572f8268@dxy.sh.intel.com> (raw)
>From 99fbdefb4d9e74e5641e892bb9fbe7cae1c1e39a Mon Sep 17 00:00:00 2001
From: Alek Du <alek.du@intel.com>
Date: Fri, 8 May 2009 12:35:48 +0800
Subject: [PATCH] INPUT: Give more precise auto repeat control for gpio_keys driver
We have a situation that for same gpio key driver, some keys can't be
auto repeatable while most of other keys are repeatable. By adding a
disable repeat flag for each button, we could precisely control that.
Signed-off-by: Alek Du <alek.du@intel.com>
---
drivers/input/keyboard/gpio_keys.c | 3 +++
include/linux/gpio_keys.h | 1 +
2 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c
index 5e9fb79..bfde124 100644
--- a/drivers/input/keyboard/gpio_keys.c
+++ b/drivers/input/keyboard/gpio_keys.c
@@ -50,6 +50,9 @@ static void gpio_keys_report_event(struct work_struct *work)
int state = (gpio_get_value(button->gpio) ? 1 : 0) ^ button->active_low;
input_event(input, type, button->code, !!state);
+ /* if button disabled auto repeat */
+ if (state && test_bit(EV_REP, input->evbit) && button->norep)
+ input_event(input, type, button->code, 0);
input_sync(input);
}
diff --git a/include/linux/gpio_keys.h b/include/linux/gpio_keys.h
index 1289fa7..ffda87c 100644
--- a/include/linux/gpio_keys.h
+++ b/include/linux/gpio_keys.h
@@ -10,6 +10,7 @@ struct gpio_keys_button {
int type; /* input event type (EV_KEY, EV_SW) */
int wakeup; /* configure the button as a wake-up source */
int debounce_interval; /* debounce ticks interval in msecs */
+ unsigned int norep:1; /* more precise auto repeat control */
};
struct gpio_keys_platform_data {
--
1.6.0.4
next reply other threads:[~2009-06-11 12:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-11 12:07 Alek Du [this message]
2009-06-24 14:29 ` [PATCH] [resend] INPUT: Give more precise auto repeat control for gpio_keys driver Du, Alek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090611200754.572f8268@dxy.sh.intel.com \
--to=alek.du@intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).