From: "Li, Yan I" <yan.i.li@intel.com>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"greg@kroah.com" <greg@kroah.com>,
yanli@infradead.org
Subject: Re: [PATCH] More i8042-reset quirks for MSI Wind-clone netbooks
Date: Wed, 17 Jun 2009 09:01:40 +0800 [thread overview]
Message-ID: <20090617010138.GA13479@thyme.bj.intel.com> (raw)
In-Reply-To: <20090616171732.GA14912@srcf.ucam.org>
On Wed, Jun 17, 2009 at 01:17:32AM +0800, Matthew Garrett wrote:
> So the touchpad on these machines doesn't work with generic Windows? I'm
> interested in the specifics, not general issues with i8042
> implementations. We've repeatedly seen that these quirk tables end up
> inadequately comprehensive and in several cases have masked the actual
> problem.
Now we have more than 99% machines work well with current i8042 code
path, and less than 1% of machines (those MSI Wind & clones) that
don't work unless being added to this list.
If we do multiple-resetting unconditionally (for all machines), we are
effectively:
1. fixing things that works well
2. make >99% machines (the good citizens) untested
This seems a change too aggressive for me. Do we have a good reason
for taking this risk?
Of course if we found the "actual problem" we'd conjure up a better
fix. But before that, I'd prefer the conservative way.
--
Best regards,
Li, Yan
Moblin Team, Opensource Technology Center, SSG, Intel
Office tel.: +86-10-82171695 (inet: 8-758-1695)
OpenPGP key: 5C6C31EF
IRC: yanli on network irc.freenode.net
next prev parent reply other threads:[~2009-06-17 1:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-15 14:16 [PATCH] More i8042-reset quirks for MSI Wind-clone netbooks Yan Li
2009-06-15 14:34 ` Matthew Garrett
2009-06-15 14:47 ` Li, Yan
2009-06-16 15:42 ` Matthew Garrett
2009-06-16 16:36 ` Alan Cox
2009-06-16 16:43 ` Matthew Garrett
2009-06-16 17:15 ` Alan Cox
2009-06-16 17:17 ` Matthew Garrett
2009-06-17 1:01 ` Li, Yan I [this message]
2009-06-17 2:51 ` Matthew Garrett
2009-06-18 0:08 ` Li, Yan
2009-06-18 15:42 ` Matthew Garrett
2009-06-19 7:16 ` Li, Yan I
2009-06-19 12:37 ` Matthew Garrett
2009-06-22 23:35 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090617010138.GA13479@thyme.bj.intel.com \
--to=yan.i.li@intel.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=greg@kroah.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=yanli@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).