linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	akpm@linux-foundation
Subject: Re: [PATCH] More i8042-reset quirks for MSI Wind-clone netbooks
Date: Wed, 17 Jun 2009 03:51:01 +0100	[thread overview]
Message-ID: <20090617025101.GA27595@srcf.ucam.org> (raw)
In-Reply-To: <20090617010138.GA13479@thyme.bj.intel.com>

On Wed, Jun 17, 2009 at 09:01:40AM +0800, Li, Yan I wrote:

> This seems a change too aggressive for me. Do we have a good reason
> for taking this risk? 

It's generally much easier to find regressions (people complain) than it 
is to find things that have never worked (people just assume Linux is 
broken).

> Of course if we found the "actual problem" we'd conjure up a better 
> fix. But before that, I'd prefer the conservative way.

Does stock Windows work on the machine? I think this really ought to be 
a pretty obvious minimal test before adding quirks to the kernel.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

  reply	other threads:[~2009-06-17  2:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-15 14:16 [PATCH] More i8042-reset quirks for MSI Wind-clone netbooks Yan Li
2009-06-15 14:34 ` Matthew Garrett
2009-06-15 14:47   ` Li, Yan
2009-06-16 15:42     ` Matthew Garrett
2009-06-16 16:36       ` Alan Cox
2009-06-16 16:43         ` Matthew Garrett
2009-06-16 17:15           ` Alan Cox
2009-06-16 17:17             ` Matthew Garrett
2009-06-17  1:01               ` Li, Yan I
2009-06-17  2:51                 ` Matthew Garrett [this message]
2009-06-18  0:08                   ` Li, Yan
2009-06-18 15:42                     ` Matthew Garrett
2009-06-19  7:16                       ` Li, Yan I
2009-06-19 12:37                         ` Matthew Garrett
2009-06-22 23:35                           ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090617025101.GA27595@srcf.ucam.org \
    --to=mjg59@srcf.ucam.org \
    --cc=akpm@linux-foundation \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).