From: Andrew Morton <akpm@linux-foundation.org>
To: "Richard Röjfors" <richard.rojfors.ext@mocean-labs.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
kwangwoo.lee@gmail.com, thierry.reding@avionic-design.de,
soni.trilok@gmail.com
Subject: Re: [PATCH 2/2] tsc2007: make platform callbacks optional
Date: Thu, 25 Jun 2009 14:23:44 -0700 [thread overview]
Message-ID: <20090625142344.d7c5b72d.akpm@linux-foundation.org> (raw)
In-Reply-To: <4A40C28E.1070109@mocean-labs.com>
On Tue, 23 Jun 2009 13:54:54 +0200
Richard R__jfors <richard.rojfors.ext@mocean-labs.com> wrote:
> The platform callbacks are only called if supplied. Makes the driver
> to fallback on only pressure calculation to decide when the pen is up.
>
Again, I don't understand the reason for the change from the above
description.
Is there some driver in the tree which does not implement
->get_pendown_state()? If so, it will oops, won't it? Which driver is
that?
Or is there some other driver which you're developing which does not
implement ->get_pendown_state()?
If the latter, why should the problem be solved in this way, rather
than implementing an empty ->get_pendown_state() within that driver?
etc. More details, please.
next prev parent reply other threads:[~2009-06-25 21:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-23 11:54 [PATCH 2/2] tsc2007: make platform callbacks optional Richard Röjfors
2009-06-25 21:23 ` Andrew Morton [this message]
2009-07-09 16:03 ` Richard Röjfors
2009-07-14 4:17 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090625142344.d7c5b72d.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=kwangwoo.lee@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard.rojfors.ext@mocean-labs.com \
--cc=soni.trilok@gmail.com \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).