Re: [patch 2.6.29-rc2] input: dm355evm_keys driver

[David Brownell <david-b@pacbell.net>]

On Monday 22 June 2009, Dmitry Torokhov wrote:
> 
> > > As you have noticed the driver is in mainline already;
> > 
> > Actually I didn't notice until just now.  It was moved
> > from input/keyboard to input/misc.  And I wasn't cc'd
> > on this at any point ... so it's no wonder I had no idea
> > what was happening!
> > 
> 
> Ah, sorry, it was me - all RC drivers live in input/misc,
> that's why I moved it there.

Moving it did break more than just config files ... see
the appended fixup patch.  I'll suggest that it go through
the input tree to keep things together, though if Sam wants
to take this through MFD he surely has that option.  :)

- Dave

p.s. Of course this is is a hybrid keypad-plus-remote
     driver.  :)  The only real issue here is having this
     change with no notice.

======== CUT HERE
From: David Brownell <dbrownell@users.sourceforge.net>

The keypad driver for the DM355 EVM got slightly broken as it merged,
since it moved from input/keyboard to input/misc and its Kconfig
symbol changed.  This patch copes with the changed Kconfig symbol.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
---
 drivers/mfd/dm355evm_msp.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/drivers/mfd/dm355evm_msp.c
+++ b/drivers/mfd/dm355evm_msp.c
@@ -32,8 +32,7 @@
  * This driver was tested with firmware revision A4.
  */
 
-#if defined(CONFIG_KEYBOARD_DM355EVM) \
-		|| defined(CONFIG_KEYBOARD_DM355EVM_MODULE)
+#if defined(CONFIG_INPUT_DM355EVM) || defined(CONFIG_INPUT_DM355EVM_MODULE)
 #define msp_has_keyboard()	true
 #else
 #define msp_has_keyboard()	false

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html