From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Daniel Mack <daniel@caiaq.de>
Cc: H Hartley Sweeten <hartleys@visionengravers.com>,
linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: rotary_encoder cleanup
Date: Mon, 29 Jun 2009 19:32:11 -0700 [thread overview]
Message-ID: <20090630023211.GC10652@dtor-d630.eng.vmware.com> (raw)
In-Reply-To: <20090623162126.GL29236@buzzloop.caiaq.de>
On Tue, Jun 23, 2009 at 06:21:26PM +0200, Daniel Mack wrote:
> On Sat, Jun 20, 2009 at 06:15:51PM -0400, H Hartley Sweeten wrote:
> > There is no need to carry the two irq numbers in the allocated memory.
> > They are only needed for the free_irq() calls during the remove. Since
> > the driver is already carrying the platform_data we can just call
> > gpio_to_irq() to get the irq number.
> >
> > Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
>
> Acked-by: Daniel Mack <daniel@caiaq.de>
>
Do we know how many encoders we need to have in the system to start
seeing the benefits (given that all these conversions increase text
size)?
--
Dmitry
next prev parent reply other threads:[~2009-06-30 2:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-20 22:15 [PATCH] Input: rotary_encoder cleanup H Hartley Sweeten
2009-06-23 16:21 ` Daniel Mack
2009-06-30 2:32 ` Dmitry Torokhov [this message]
2009-06-30 15:56 ` H Hartley Sweeten
2009-07-01 18:33 ` Daniel Mack
2009-07-01 18:45 ` H Hartley Sweeten
2009-07-01 18:49 ` Daniel Mack
2009-07-07 18:32 ` H Hartley Sweeten
2009-07-08 6:56 ` Dmitry Torokhov
2009-07-08 21:47 ` H Hartley Sweeten
2009-07-09 4:17 ` Dmitry Torokhov
2009-07-09 16:31 ` H Hartley Sweeten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090630023211.GC10652@dtor-d630.eng.vmware.com \
--to=dmitry.torokhov@gmail.com \
--cc=daniel@caiaq.de \
--cc=hartleys@visionengravers.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).