From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH] Input: rotary_encoder cleanup Date: Mon, 29 Jun 2009 19:32:11 -0700 Message-ID: <20090630023211.GC10652@dtor-d630.eng.vmware.com> References: <20090623162126.GL29236@buzzloop.caiaq.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from rv-out-0506.google.com ([209.85.198.232]:55006 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754319AbZF3CcM (ORCPT ); Mon, 29 Jun 2009 22:32:12 -0400 Received: by rv-out-0506.google.com with SMTP id f6so1390435rvb.1 for ; Mon, 29 Jun 2009 19:32:15 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20090623162126.GL29236@buzzloop.caiaq.de> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Daniel Mack Cc: H Hartley Sweeten , linux-input@vger.kernel.org On Tue, Jun 23, 2009 at 06:21:26PM +0200, Daniel Mack wrote: > On Sat, Jun 20, 2009 at 06:15:51PM -0400, H Hartley Sweeten wrote: > > There is no need to carry the two irq numbers in the allocated memory. > > They are only needed for the free_irq() calls during the remove. Since > > the driver is already carrying the platform_data we can just call > > gpio_to_irq() to get the irq number. > > > > Signed-off-by: H Hartley Sweeten > > Acked-by: Daniel Mack > Do we know how many encoders we need to have in the system to start seeing the benefits (given that all these conversions increase text size)? -- Dmitry