From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH v2] input:Add keypad header file for w90p910 Date: Mon, 13 Jul 2009 21:29:15 -0700 Message-ID: <20090714042914.GB2822@dtor-d630.eng.vmware.com> References: <4A55B406.90203@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from rv-out-0506.google.com ([209.85.198.228]:20633 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751440AbZGNE3T (ORCPT ); Tue, 14 Jul 2009 00:29:19 -0400 Received: by rv-out-0506.google.com with SMTP id f6so763368rvb.1 for ; Mon, 13 Jul 2009 21:29:19 -0700 (PDT) Content-Disposition: inline In-Reply-To: <4A55B406.90203@gmail.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Wan ZongShun Cc: linux-arm-kernel , Trilok Soni , linux-input@vger.kernel.org, Russell King Hi Wan, On Thu, Jul 09, 2009 at 05:10:30PM +0800, Wan ZongShun wrote: > Dear sirs, > > This is a header file for supporting my keypad driver, > a few days ago,I have submitted it, Now, for updating > keypad driver, I submit new patch updated again! > > Signed-off-by: Wan ZongShun > Please submit this header file together with the keypad driver, I believe there is an updated version coming, right? > + > +#define KEY(row, col, val) (((row) << 28) | ((col) << 24) | (val)) > + Please use definitions from include/linux/input/matrix_keypad.h found in my tree. -- Dmitry