* [PATCH 04/06][RESEND] Fix compilation warning for drivers/input/touchscreen/htcpen.c
@ 2009-07-21 2:23 Subrata Modak
2009-07-21 5:21 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Subrata Modak @ 2009-07-21 2:23 UTC (permalink / raw)
To: Pau Oliva Fora, linux-input
Cc: Sachin P Sant, David Howells, Subrata Modak, Balbir Singh, LKML
gcc 4.4.1 generates the following build warning on i386:
CC drivers/input/touchscreen/htcpen.o
drivers/input/touchscreen/htcpen.c:50: warning: 'pnp_ids' defined but not used
Fix this by removing the static keyword when you are actually exporting
that structure. This patch was earlier posted on 14th July 2009:
http://lkml.org/lkml/2009/7/14/362,
Signed-off-by: Subrata Modak<subrata@linux.vnet.ibm.com>
---
--- a/drivers/input/touchscreen/htcpen.c 2009-05-20 10:40:54.000000000 +0530
+++ b/drivers/input/touchscreen/htcpen.c 2009-07-15 06:15:34.000000000 +0530
@@ -47,7 +47,7 @@ static int invert_y;
module_param(invert_y, bool, 0644);
MODULE_PARM_DESC(invert_y, "If set, Y axis is inverted");
-static struct pnp_device_id pnp_ids[] = {
+struct pnp_device_id pnp_ids[] = {
{ .id = "PNP0cc0" },
{ .id = "" }
};
---
Regards--
Subrata
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 04/06][RESEND] Fix compilation warning for drivers/input/touchscreen/htcpen.c
2009-07-21 2:23 [PATCH 04/06][RESEND] Fix compilation warning for drivers/input/touchscreen/htcpen.c Subrata Modak
@ 2009-07-21 5:21 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2009-07-21 5:21 UTC (permalink / raw)
To: Subrata Modak
Cc: Pau Oliva Fora, linux-input, Sachin P Sant, David Howells,
Balbir Singh, LKML
Hi Subrata,
On Tue, Jul 21, 2009 at 07:53:44AM +0530, Subrata Modak wrote:
> gcc 4.4.1 generates the following build warning on i386:
>
> CC drivers/input/touchscreen/htcpen.o
> drivers/input/touchscreen/htcpen.c:50: warning: 'pnp_ids' defined but not used
>
> Fix this by removing the static keyword when you are actually exporting
> that structure. This patch was earlier posted on 14th July 2009:
> http://lkml.org/lkml/2009/7/14/362,
>
> Signed-off-by: Subrata Modak<subrata@linux.vnet.ibm.com>
Umm, no, we don't export this particular structure, we are exporting
another structure referencing this. Are you compiling without module
support by any chance?
> ---
>
> --- a/drivers/input/touchscreen/htcpen.c 2009-05-20 10:40:54.000000000 +0530
> +++ b/drivers/input/touchscreen/htcpen.c 2009-07-15 06:15:34.000000000 +0530
> @@ -47,7 +47,7 @@ static int invert_y;
> module_param(invert_y, bool, 0644);
> MODULE_PARM_DESC(invert_y, "If set, Y axis is inverted");
>
> -static struct pnp_device_id pnp_ids[] = {
> +struct pnp_device_id pnp_ids[] = {
> { .id = "PNP0cc0" },
> { .id = "" }
> };
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-07-21 5:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-21 2:23 [PATCH 04/06][RESEND] Fix compilation warning for drivers/input/touchscreen/htcpen.c Subrata Modak
2009-07-21 5:21 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).