From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Mike Rapoport <mike@compulab.co.il>
Cc: Eric Miao <eric.y.miao@gmail.com>, linux-input@vger.kernel.org
Subject: Re: A few changes to pxa27x_keypad
Date: Thu, 23 Jul 2009 02:24:57 -0700 [thread overview]
Message-ID: <20090723092456.GA2512@dtor-d630.eng.vmware.com> (raw)
In-Reply-To: <4A6827C9.2090203@compulab.co.il>
On Thu, Jul 23, 2009 at 12:05:13PM +0300, Mike Rapoport wrote:
>
>
> Dmitry Torokhov wrote:
> > On Wed, Jul 22, 2009 at 11:30:44PM -0700, Dmitry Torokhov wrote:
> >> On Tue, Jul 21, 2009 at 01:44:56PM +0300, Mike Rapoport wrote:
> >>> Hi Dmitry,
> >>>
> >>> Dmitry Torokhov wrote:
> >>>> Hi Eric,
> >>>>
> >>>> I made a few adjustments to the pxa27x_keypad driver and was wondering
> >>>> if you would be able to give it a sping and check if I broke it or not.
> >>> Apparently not :)
> >>> Tested-by: Mike Rapoport <mike@compulab.co.il>
> >>>
> >> Cool, thanks for testing. I have another one for you then ;)
> >>
> >> TIA!
> >>
> >
> > Umm.. this one is hopefully better...
> >
> > Input: pxa27x_keypad - switch to using dev_pm_ops
> >
> > Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
>
> I've got this with 2.6.31-rc3
> CC drivers/input/keyboard/pxa27x_keypad.o
> drivers/input/keyboard/pxa27x_keypad.c:591: warning: initialization discards
> qualifiers from pointer target type
>
Ah, yes... it needs my patch constifying the pm pointer that Rafael
picked up. Thank you for testing.
--
Dmitry
prev parent reply other threads:[~2009-07-23 9:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-21 8:08 A few changes to pxa27x_keypad Dmitry Torokhov
2009-07-21 10:44 ` Mike Rapoport
2009-07-23 6:30 ` Dmitry Torokhov
2009-07-23 7:28 ` Dmitry Torokhov
2009-07-23 7:36 ` Dmitry Torokhov
2009-09-04 5:20 ` Dmitry Torokhov
2009-09-04 7:45 ` Eric Miao
2009-09-04 8:17 ` Dmitry Torokhov
2009-07-23 9:05 ` Mike Rapoport
2009-07-23 9:24 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090723092456.GA2512@dtor-d630.eng.vmware.com \
--to=dmitry.torokhov@gmail.com \
--cc=eric.y.miao@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=mike@compulab.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).