From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH 13/22] Input: Add support for the WM831x ON pin
Date: Mon, 27 Jul 2009 16:41:07 +0100 [thread overview]
Message-ID: <20090727154107.GA10526@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <20090727161151.A9D36526EC9@mailhub.coreip.homeip.net>
On Mon, Jul 27, 2009 at 08:38:05AM -0700, Dmitry Torokhov wrote:
> On Mon, Jul 27, 2009 at 02:46:03PM +0100, Mark Brown wrote:
> > + * wm831x-on.c - WM831X ON pind river
> "Pind river"? ;)
Err, yes. Highly innovative new technology!
> > +static irqreturn_t wm831x_on_irq(int irq, void *data)
> > +{
> > + struct wm831x_on *wm831x_on = data;
> > +
> > + schedule_work(&wm831x_on->work.work);
> schedule_delayed_work(&wm831x_on->work, 0); - I prefer not to expose
> delayed work implementation details.
> Other than that:
> Acked-by: Dmitry Torokhov <dtor@mail.ru>
> Freel free to push this with the rest of the series. If that does not
> work out let me know and I will get this driver into my tree.
OK, I'll fix that when I resend. Thanks.
next prev parent reply other threads:[~2009-07-27 15:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-27 13:45 [PATCH 0/22] WM831x drivers Mark Brown
2009-07-27 13:46 ` [PATCH 13/22] Input: Add support for the WM831x ON pin Mark Brown
2009-07-27 15:38 ` Dmitry Torokhov
2009-07-27 15:41 ` Mark Brown [this message]
2009-07-28 14:13 ` [PATCH] " Mark Brown
2009-08-04 11:35 ` [PATCH 0/22] WM831x drivers Samuel Ortiz
2009-08-04 11:44 ` Liam Girdwood
2009-08-04 14:07 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090727154107.GA10526@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).