Re: [PATCH] Enable ADC Filter on UCB1400

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Thu, Jul 30, 2009 at 07:22:24PM +0200, Marek Vasut wrote:
> Hi!
> 
> please consider applying the following patch. I tested it on Palm Tungsten|C 
> (ADCSYNC connected, both disabled and enabled through module parameter) and a 
> friend of mine tested it on Toradex Colibri (ADCSYNC not connected, disabled).
> 
> Thanks
> 
> From 65cb92df1aba511fbc44d62fa25d5cf38a687952 Mon Sep 17 00:00:00 2001
> From: Marek Vasut <marek.vasut@gmail.com>
> Date: Thu, 30 Jul 2009 19:03:10 +0200
> Subject: [PATCH] Enable ADC Filter on UCB1400
> 
> This patch enables ADC filtering on UCB1400 codec by default. The
> benefit from this change is mostly on some Colibri boards where the
> ADCSYNC pin of the UCB1400 codec isn't connected causing the touchscreen
> to jitter very badly. This change has no visible effect on boards where
> the ADCSYNC pin is connected.
> 

I wonder if it would not be safer to only enable filtering if platform
requests it (via platform data)?

-- 
Dmitry