From: Pavel Machek <pavel@ucw.cz>
To: Trilok Soni <soni.trilok@gmail.com>
Cc: Greg KH <greg@kroah.com>,
kernel list <linux-kernel@vger.kernel.org>,
swetland@google.com, linux-input@vger.kernel.org
Subject: Re: HTC Dream for staging: add support for input on GPIO pins
Date: Sat, 8 Aug 2009 23:44:54 +0200 [thread overview]
Message-ID: <20090808214454.GB24153@elf.ucw.cz> (raw)
In-Reply-To: <5d5443650908080942l50d91d31qb23c494affdf6850@mail.gmail.com>
On Sat 2009-08-08 22:12:46, Trilok Soni wrote:
> Hi Pavel,
>
> On Sat, Aug 8, 2009 at 6:33 PM, Pavel Machek<pavel@ucw.cz> wrote:
> > From: Arve Hj?nnev?g <arve@android.com>
> >
> > Support for input devices connected to GPIO pins. This adds support
> > for HTC Dream's keyboard and its trackball. Generic support already
> > exists for keyboard on GPIO, but this one is more advanced because it
> > can detect shadow key presses (and actually works with Dream :-).
> >
> > (It also contains Kconfig/Makefile changes, including some that were
> > missing from previous commit. Sorry.)
>
> I don't see any importance of gpio_matrix.c when we already have
> generic gpio matrix driver mainlined. I would suggest to remove those
> bits from this patch. I have added linux-input ML.
Well, I'm trying for staging merge at this point. Reasons why
gpio_matrix is there are:
1) it is non-trivial to remove
2) it has some features mainline lacks
3) HTC Dream actually works with it
(and 4) I'd like to submit code as Arve wrote it, then transform/clean
it up in staging).
Of course, relevant features will need to be extracted from
gpio_matrix and merged at the right places, and that needs to happen
before move from staging/, but I'd like to have working keyboard in
the meantime.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2009-08-08 21:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090808130315.GA12930@elf.ucw.cz>
2009-08-08 16:42 ` HTC Dream for staging: add support for input on GPIO pins Trilok Soni
2009-08-08 21:44 ` Pavel Machek [this message]
2009-08-10 7:31 ` Trilok Soni
2009-08-09 13:01 ` Pavel Machek
2009-08-10 22:26 ` Arve Hjønnevåg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090808214454.GB24153@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=greg@kroah.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=soni.trilok@gmail.com \
--cc=swetland@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).