From: Marek Vasut <marek.vasut@gmail.com>
To: "Ba, Zheng" <zheng.ba@intel.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Subject: Re: FW: [PATCH 1/1] input: keypad controller driver for Intel low power Moorestown platform
Date: Wed, 12 Aug 2009 11:06:40 +0200 [thread overview]
Message-ID: <200908121106.40691.marek.vasut@gmail.com> (raw)
In-Reply-To: <61563CE63B4F854986A895DA7AD3C17709DB43A635@pdsmsx502.ccr.corp.intel.com>
Dne St 12. srpna 2009 10:45:08 Ba, Zheng napsal(a):
> Hi Dmitry,
>
> Here's the second version with changes inline per your comments, please
> help review. Thanks!
>
> Thanks,
> Zheng
>
Hi!
just a quick skim over the code revealed a few things:
1) cant you make the NumLk and Fn keys into normal keys (therefore getting rid
of those three keymaps) and make the keymap stuff in userspace?
2) cant you just use the GPIO-driven matrix keypad driver instead of this?
Cheers!
next prev parent reply other threads:[~2009-08-12 9:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-06 4:00 FW: [PATCH 1/1] input: keypad controller driver for Intel low power Moorestown platform Ba, Zheng
2009-05-07 16:45 ` Dmitry Torokhov
2009-05-08 12:45 ` Ba, Zheng
2009-08-12 7:54 ` Ba, Zheng
2009-08-12 8:45 ` Ba, Zheng
2009-08-12 9:06 ` Marek Vasut [this message]
2009-08-12 9:25 ` Ba, Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908121106.40691.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=zheng.ba@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).