From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH] input: Rename keypad and ts platform driver for w90p910 Date: Mon, 17 Aug 2009 22:25:07 -0700 Message-ID: <20090818055620.73F65526EA5@mailhub.coreip.homeip.net> References: <4A88D499.30302@gmail.com> <20090817084848.6720F526EA5@mailhub.coreip.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from rv-out-0506.google.com ([209.85.198.226]:3785 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751478AbZHRFZK (ORCPT ); Tue, 18 Aug 2009 01:25:10 -0400 Received: by rv-out-0506.google.com with SMTP id f6so929726rvb.1 for ; Mon, 17 Aug 2009 22:25:11 -0700 (PDT) Content-Disposition: inline In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Wan ZongShun Cc: linux-arm-kernel , linux-input@vger.kernel.org Hi Wan, On Mon, Aug 17, 2009 at 04:44:03PM +0800, Wan ZongShun wrote: > Dear Dmitry, > > Sir, Due to only w90p910 was renamed, other CPUs of the series > originally was named after NUC9xx, > the ts and keypad was public use by w90p910 ,nuc950 and nuc920, OK, I see. so, if > the 'w90p910-ts' and 'w90p910-keypad' could not be renamed ,I have to > make the platform device names of nuc920 and nuc960 named after > 'w90p910-ts' and 'w90p910-keypad' too, Hmm, I think it is so confused. May I suggest calling the driver/devices nuc9xx-ts and nuc9xx-ts? Then you should have some wiggle room. Also I think you should push out the patches changing driver names together with your platform code (and not through subsystem trees), otheriwse there will be a period when drivers stop binding to your devices. Just make sure you get Acks from the maintainers and you should be set. And please adjust the Kconfig entries to mention the other chipsets as well. -- Dmitry