From: Tony Lindgren <tony@atomide.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Syed Rafiuddin <rafiuddin.syed@ti.com>,
soni.trilok@gmail.com, linux-input@vger.kernel.org,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH-v2][RFC] OMAP4: Keypad Support for OMAP4430
Date: Fri, 28 Aug 2009 09:16:45 -0700 [thread overview]
Message-ID: <20090828161645.GM25828@atomide.com> (raw)
In-Reply-To: <20090827065208.9B1C0526EC9@mailhub.coreip.homeip.net>
* Dmitry Torokhov <dmitry.torokhov@gmail.com> [090826 23:20]:
> On Tue, Aug 25, 2009 at 04:09:03PM +0530, Syed Rafiuddin wrote:
> > From: Syed Rafiuddin <rafiuddin.syed@ti.com>
> >
> > Resending with correct Subject.
> >
> > This patch Adds Keypad support on OMAP4.And adds
> > OMAP4 register addresses and configures them for OMAP4.
> >
> >
> > This patch has been updated as per the comments received from
> > Trilok Soni to remove GPIO based omap2 keypad logic from omap_keypad.c
> > (http://www.mail-archive.com/linux-omap@vger.kernel.org/msg14570.html)
> > Matrix_keypad.c (gpio based keypad driver) can be used in OMAP2,
> > which is not tested on OMAP2 since unavailability of omap2 target's.
> >
>
> So has omap2 been switched over to matrix-keypad? Otherwise ripping
> omap2 support from omap-keypad is premature.
Hmm yeah that should be a separate patch that swithces 24xx to use
the GPIO keypad driver and removes the related logic from this patch.
Tony
prev parent reply other threads:[~2009-08-28 16:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-25 10:39 [PATCH-v2][RFC] OMAP4: Keypad Support for OMAP4430 Syed Rafiuddin
2009-08-27 6:19 ` Dmitry Torokhov
2009-08-28 16:16 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090828161645.GM25828@atomide.com \
--to=tony@atomide.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rafiuddin.syed@ti.com \
--cc=soni.trilok@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).