From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Eric Miao <eric.y.miao@gmail.com>
Cc: Mike Rapoport <mike@compulab.co.il>, linux-input@vger.kernel.org
Subject: Re: A few changes to pxa27x_keypad
Date: Fri, 4 Sep 2009 01:17:55 -0700 [thread overview]
Message-ID: <20090904085054.0FFCC526EA5@mailhub.coreip.homeip.net> (raw)
In-Reply-To: <f17812d70909040045j688f1ae8la7b67e0acc813f9d@mail.gmail.com>
On Fri, Sep 04, 2009 at 03:45:42PM +0800, Eric Miao wrote:
> On Fri, Sep 4, 2009 at 1:20 PM, Dmitry
> Torokhov<dmitry.torokhov@gmail.com> wrote:
> > On Thu, Jul 23, 2009 at 12:36:25AM -0700, Dmitry Torokhov wrote:
> >> On Thu, Jul 23, 2009 at 12:28:02AM -0700, Dmitry Torokhov wrote:
> >> > On Wed, Jul 22, 2009 at 11:30:44PM -0700, Dmitry Torokhov wrote:
> >> > > On Tue, Jul 21, 2009 at 01:44:56PM +0300, Mike Rapoport wrote:
> >> > > > Hi Dmitry,
> >> > > >
> >> > > > Dmitry Torokhov wrote:
> >> > > > > Hi Eric,
> >> > > > >
> >> > > > > I made a few adjustments to the pxa27x_keypad driver and was wondering
> >> > > > > if you would be able to give it a sping and check if I broke it or not.
> >> > > >
> >> > > > Apparently not :)
> >> > > > Tested-by: Mike Rapoport <mike@compulab.co.il>
> >> > > >
> >> > >
> >> > > Cool, thanks for testing. I have another one for you then ;)
> >> > >
> >> > > TIA!
> >> > >
> >> >
> >> > Umm.. this one is hopefully better...
> >> >
> >>
> >> And another one implementing keymap manipulation.
> >>
> >
> > *ping* Any chance you could try this one out for me? Pretty please...
> >
>
> Hi Dmitry,
>
> Mike has already tested this,
Ah, my bad then... I understood that he only tested dev_pm_ops
conversion (the first patch) and not both.
> and I tested this again on my Littleton/pxa3xx,
> it works pretty good, and the change looks quite OK, so if you need my Ack,
> here it goes:
>
> Acked-by: Eric Miao <eric.y.miao@gmail.com>
Thank you, much appreciated.
--
Dmitry
next prev parent reply other threads:[~2009-09-04 8:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-21 8:08 A few changes to pxa27x_keypad Dmitry Torokhov
2009-07-21 10:44 ` Mike Rapoport
2009-07-23 6:30 ` Dmitry Torokhov
2009-07-23 7:28 ` Dmitry Torokhov
2009-07-23 7:36 ` Dmitry Torokhov
2009-09-04 5:20 ` Dmitry Torokhov
2009-09-04 7:45 ` Eric Miao
2009-09-04 8:17 ` Dmitry Torokhov [this message]
2009-07-23 9:05 ` Mike Rapoport
2009-07-23 9:24 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090904085054.0FFCC526EA5@mailhub.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=eric.y.miao@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=mike@compulab.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).