From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: "Song, Barry" <Barry.Song@analog.com>,
Barry Song <21cnbao@gmail.com>,
"Hennerich, Michael" <Michael.Hennerich@analog.com>,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
uclinux-dist-devel@blackfin.uclinux.org
Subject: Re: [Uclinux-dist-devel] [PATCH] input/keyboard: add ADP5588 QWERTYI2C Keyboard Input device driver
Date: Tue, 15 Sep 2009 21:49:57 -0700 [thread overview]
Message-ID: <20090916044957.GE2756@core.coreip.homeip.net> (raw)
In-Reply-To: <8bd0f97a0909152125l29683107h93837b7388a9d20f@mail.gmail.com>
On Wed, Sep 16, 2009 at 12:25:56AM -0400, Mike Frysinger wrote:
> On Wed, Sep 16, 2009 at 00:18, Song, Barry wrote:
> >From: Mike Frysinger
> >>On Tue, Sep 15, 2009 at 23:49, Barry Song wrote:
> >>> Even though CONFIG_GENERIC_HARDIRQS is almost always "y", in case
> >>> CONFIG_GENERIC_HARDIRQS is "n" not "y", threaded_irq will become
> >>> original irq, drivers will not work. So is it necessary to check the
> >>> dependence of GENERIC_HARDIRQS while using threaded_irq?
> >>
> >>when is GENERIC_HARDIRQS not "y" ? a quick check shows only s390/m68k
> >>dont set it to "y" in their arch Kconfig ? s390 isnt going to use any
> >>of these drivers, and m68k will eventually update (m68knommu already
> >>has !?).
> >
> > SPARC32 is "n" too. I am not caring about only these several drivers. I just want to find whether that can be a generic problem while using threaded_irq in any driver.
>
> SPARC32 too is dead, so dont sweat it. it's safe to assume
> GENERIC_HARDIRQS is "y" in the code we write like these input drivers.
I agree here.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-09-16 4:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-14 22:18 [PATCH] input/keyboard: add ADP5588 QWERTY I2C Keyboard Input device driver Mike Frysinger
2009-09-15 6:20 ` Dmitry Torokhov
2009-09-15 11:19 ` Mike Frysinger
2009-09-15 16:26 ` Dmitry Torokhov
2009-09-15 16:46 ` Mike Frysinger
2009-09-15 17:17 ` Dmitry Torokhov
2009-09-16 3:49 ` Barry Song
2009-09-16 4:03 ` Mike Frysinger
2009-09-16 4:18 ` [Uclinux-dist-devel] [PATCH] input/keyboard: add ADP5588 QWERTYI2C " Song, Barry
2009-09-16 4:25 ` Mike Frysinger
2009-09-16 4:49 ` Dmitry Torokhov [this message]
2009-09-16 21:07 ` [PATCH] input/keyboard: add ADP5588 QWERTY I2C " Robin Getz
2009-09-16 0:49 ` [PATCH v2] " Mike Frysinger
[not found] ` <1253062178-18196-1-git-send-email-vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
2009-09-16 5:02 ` Dmitry Torokhov
2009-09-16 12:55 ` [Uclinux-dist-devel] " Mike Frysinger
2009-09-16 16:33 ` Dmitry Torokhov
2009-09-16 18:20 ` [PATCH v3] " Mike Frysinger
2009-09-18 5:42 ` Dmitry Torokhov
2009-09-21 16:45 ` [Uclinux-dist-devel] [PATCH v2] " Mike Frysinger
[not found] ` <8bd0f97a0909210945s5e3d9613pa7a72271ec6b47bc-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-09-21 16:55 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090916044957.GE2756@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=21cnbao@gmail.com \
--cc=Barry.Song@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).