From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH] Input: add MAX7359 key switch controller driver, v2 Date: Fri, 18 Sep 2009 09:39:27 -0700 Message-ID: <20090918163927.GA365@core.coreip.homeip.net> References: <4A5BF6F0.6020403@samsung.com> <001801ca044c$428839d0$c798ad70$%szyprowski@samsung.com> <20090714082452.GH2822@dtor-d630.eng.vmware.com> <002a01ca0462$8b750a90$a25f1fb0$%szyprowski@samsung.com> <5d5443650907140211i4c6e4a49q9c055dc1e91071da@mail.gmail.com> <002b01ca046c$7f9fd240$7edf76c0$%szyprowski@samsung.com> <5d5443650907140323l6cc06151nbec94d5d8646c60a@mail.gmail.com> <003f01ca051c$0e8d12b0$2ba73810$%szyprowski@samsung.com> <20090916085749.GL2756@core.coreip.homeip.net> <4AB3416F.6010004@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-fx0-f217.google.com ([209.85.220.217]:35956 "EHLO mail-fx0-f217.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752291AbZIRQjd (ORCPT ); Fri, 18 Sep 2009 12:39:33 -0400 Content-Disposition: inline In-Reply-To: <4AB3416F.6010004@samsung.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Joonyoung Shim Cc: Marek Szyprowski , 'Trilok Soni' , 'Kim Kyuwon' , 'Kim Kyuwon' , 'LKML' , linux-input@vger.kernel.org, 'Kyungmin Park' Hi Joonyoung, On Fri, Sep 18, 2009 at 05:14:39PM +0900, Joonyoung Shim wrote: > > Hi, Dmitry. > > I tested your patch with threaded IRQ. Because the interrupt of the > MAX7359 device is the low level detecting, i should add the IRQF_ONESHOT > flag on request_threaded_irq(). If it is added IRQF_ONESHOT flag, the it > operates well. Thank you for testing. > Do you want i send the patch? No, I fixed it locally. I took the liberty of marking the patch as "Tested-by" you, I hope you don't mind. -- Dmitry